openj9
openj9 copied to clipboard
Should AOT method relocation after local AOT compilation be an InterruptibleOperation?
Clang informs me that in this block of code, responsible for relocating a freshly-compiled AOT method:
https://github.com/eclipse-openj9/openj9/blob/110ef95462c09cd7b94e75500133166b671d12fe/runtime/compiler/control/CompilationThread.cpp#L10417-L10432
we create and then immediately destroy the TR::CompilationInfoPerThreadBase::InterruptibleOperation
object that is created, because we don't name the object. This is probably an oversight. I think that relocation in other circumstances is considered to be interruptible - the other calls to prepareRelocateAOTCodeAndData
(for local AOT loads, and for relocating methods received from the JITServer) appear to occur down the call stack from TR::CompilationInfoPerThreadBase::compile()
while that function is holding InterruptibleOperation compilingMethodBody(*this)
.
Attn @mpirvu.