openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

Open XL Toolchain Changes

Open Deigue opened this issue 1 year ago • 7 comments

Contains all the initial required toolchain changes to start using Open XL compiler with z/OS builds.


Keeping as draft state until I have verified it does not interfere with z/OS XLC Builds.

Deigue avatar Jun 07 '24 18:06 Deigue

@joransiu @keithc-ca Created draft PR for toolchain changes for some early feedback. Let me know if I should add/tag anyone who might recommend good practice changes that might be needed/missing from these.

Deigue avatar Jun 07 '24 18:06 Deigue

I will undo the UMA/mk updates (they were some ported commits of some much earlier attempts at open xl compilation) and verify that it doesn't impact the current compilation with java 21, along with the above suggestions. Thanks for the feedback.

Deigue avatar Jun 10 '24 16:06 Deigue

We'll also have to verify IBM Java 8 compilation isn't impacted.

pshipton avatar Jun 10 '24 18:06 pshipton

Removed all changes that aren't related to use of cmake and addressed the comments above or added comments as necessary. I have also verified now that this maintains the compilation progress so-far for Open XL.

Pending verification of a standard xlc build and a java 8 build to ensure no impact.

Deigue avatar Jun 20 '24 18:06 Deigue

Removed compiler.mk and indented the changes in runtime/cmake/platform/os/zos.cmake appropriately.

j21 passed

Deigue avatar Jun 26 '24 16:06 Deigue

Comments above addressed ... Launched builds j21: passed and java 8: success, unrelated 3 errors to verify https://github.com/eclipse-openj9/openj9/commit/3d59835a9ce3a54cb3e6cfb0a17dfb05cef4803f

Once those check out, will bring PR out of draft.

Deigue avatar Jun 26 '24 20:06 Deigue

Thanks, I've addressed the above comments.

Deigue avatar Aug 28 '24 17:08 Deigue

@keithc-ca This one is ready for a re-check.

Deigue avatar Sep 18 '24 18:09 Deigue

Rebased with master, confirmed passing with java 8 and java 21 builds.

Deigue avatar Oct 02 '24 15:10 Deigue

Jenkins compile aix jdk21

keithc-ca avatar Feb 25 '25 18:02 keithc-ca