openj9
openj9 copied to clipboard
eclipse-openj9
Add -XX:CRaCRestoreFrom=PATH tests
Issue: https://github.com/eclipse-openj9/openj9/issues/19261 Signed-off-by: Amarpreet Singh [email protected]
Any further comments on this PR?
I don't even remember seeing the review request. I'll put this on my list.
Dear @keithc-ca, I hope you are doing well, and I would like to inform you that this PR should be reviewed by you in order to complete it provided that it is on your list.
Now the conflicts are resolved and I would like this PR to be tested before it considered to be merged.
You can (and should) do testing yourself without needing to wait for a review.
Review will be re-requested for your feedback after I run the tests based on the instructions in the README file that is in the openj9/test directory.
Directory and the instructions in it were good because it led me to the build instructions for OpenJ9 V21 on a Mac and I will make progress after I obtain an update on my Apple account in order to install the latest version of Xcode and start preparing my machine.
Machine setup is blocked because of my Apple account and I would like to know if there a community machine that I can access in order to build and run the tests for the changes in this PR.
PR of this kind requires a machine that is setup to build and test OpenJ9, and @keithc-ca I would like to access a machine that has a good setup in order to build and test OpenJ9 for the code changes in this PR.
If you don't have access to a Linux system, I suggest you follow the instructions to create a docker image in which you can build and test this.
This cannot be built on my Mac machine because it has the arm64 architecture, which is unsupported to build a docker image for OpenJ9, and therefore I would like a machine that has a good setup in order to build and test OpenJ9 for the code changes in this PR.
You can use VMWare/Virtual Box or something similar to create a linux instance on you machine.
Machine of mine will attempt to utilize VirtualBox in order to build and test OpenJ9 for the code changes in this PR.
PR update is that my attempt to build OpenJ9 on my Mac machine with VirtualBox did not work, and I have regained access to my Apple acount in order to build OpenJ9 on my machine for the code changes in this PR.
PR update is that VMWare and VirtualBox cannot be utilized to build OpenJ9 on my Mac machine because they only supports arm64 virtual machines, which are not compatible with OpenJ9, and building it locally using docker x86_64 emulation is not supported because of missing system libraries associated with glibc, and therefore I would like you to reconsider my request of obtaining a community machine with good setup in order to build and test OpenJ9 for the code changes in this PR.
arm64 virtual machines, which are not compatible with OpenJ9
I expect you would be creating a Linux virtual machine (running on arm64), which definitely is supported by OpenJ9. If I misunderstand your comment, please clarify.
Clarifying that I created an arm64 Linux virutal machine on my Mac machine with VMWare and VirtualBox, and in both cases I enountered an error regarding arm64 not being unsupported during my initial setup with docker in order to build OpenJ9 for the code changes in this PR.
If you create a Linux arm64 virtual machine, you don't need to bring docker into it. However, the docker script can be a guide as to which packages you will need to install.
To install the dependencies of OpenJ9 properly on the arm64 Linux virtual machine, I will attempt the non-docker instructions on the virtual machine in order to build OpenJ9 for the code changes in this PR.
PR update is that I have built OpenJ9 on a VirtualBox linux virtual machine that is running on my arm64 Mac machine, and I will proceed to test OpenJ9 for the code changes in this PR.