openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

Correctly initialize walkState values when calling walkStackFrames

Open fengxue-IS opened this issue 1 year ago • 1 comments

After a thread's stackWalkState is used, we don't reset the fields to 0 but expects future code uses to set the parameters to the expected value before calling walkStackFrames. This change fixes walkWrapperImpl where userData1 is not properly set.

Fixes: #18696 Fixes: #18961

fengxue-IS avatar Feb 16 '24 16:02 fengxue-IS

Personal build, build failures due to network issue, sanity.functional test failure is unrelated.

@keithc-ca can you please take a look at this.

fengxue-IS avatar Feb 16 '24 16:02 fengxue-IS

Jenkins test sanity alinux jdk17,jdk22

keithc-ca avatar Feb 20 '24 17:02 keithc-ca

Exclude test (java/lang/StackWalker/CallerSensitiveMethod/Main.java) passed in https://openj9-jenkins.osuosl.org/job/Grinder/3319.

keithc-ca avatar Feb 20 '24 20:02 keithc-ca

The most recent personal build is here.

keithc-ca avatar Feb 20 '24 20:02 keithc-ca

There was one CRIU test failure which seems unrelated to this change.

keithc-ca avatar Feb 20 '24 21:02 keithc-ca