openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

Enable VectorAPI in Java 22

Open gita-omr opened this issue 1 year ago • 2 comments

  • add new parameter to load and store intrinsics

gita-omr avatar Feb 16 '24 01:02 gita-omr

Is it still going to work for versions prior to jdk22?

pshipton avatar Feb 16 '24 14:02 pshipton

Is it still going to work for versions prior to jdk22?

Good question: no it will not.

gita-omr avatar Feb 16 '24 15:02 gita-omr

@gita-omr Can you use ifdefs or support both versions of the method?

tajila avatar Mar 05 '24 22:03 tajila

@gita-omr Can you use ifdefs or support both versions of the method?

Sorry, I probably should've mentioned earlier: by support I did not mean functional support. These tests try to check that at least some optimization happens. Since Vector API is still an incubator I doubt we need to optimize it in releases other than the latest at any given time, especially since we optimize only a subset of Vector API methods anyway.

Functional Vector API tests of course should be passing.

@TobiAjila @pshipton

gita-omr avatar Mar 05 '24 23:03 gita-omr

Fixed line endings

gita-omr avatar Mar 18 '24 20:03 gita-omr

jenkins compile amac jdk22

pshipton avatar Mar 18 '24 21:03 pshipton

Run the jdk22 jdk_vector_*_j9 testing that was previously failing https://github.com/eclipse-openj9/openj9/issues/18704 https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3394 - passed

pshipton avatar Mar 19 '24 03:03 pshipton

Changed to #if JAVA_SPEC_VERSION <= 21

gita-omr avatar Mar 19 '24 16:03 gita-omr