Valhalla : Access is not abstract and does not override abstract method isPrimitiveClass(Class<?>) in JavaLangAccess

[JasonFengJ9]

Latest valhalla local build failure after resolving merging conflicts:

build/macosx-x86_64-server-release/support/j9jcl/java.base/share/classes/java/lang/Access.java:67: error: Access is not abstract and does not override abstract method isPrimitiveClass(Class<?>) in JavaLangAccess
final class Access implements JavaLangAccess {

In addition, there is another error - reference not found Class#accessFlags().

src/java.base/share/classes/java/lang/reflect/Modifier.java:40: error: reference not found
 * @see Class#accessFlags()

FYI @hangshao0

[hangshao0]

For the error regarding Class#accessFlags(), a new public API public Set<AccessFlag> accessFlags() is introduced in jdknext (Java 20), and OpenJ9 is missing the implementation. This is more like a jdknext issue rather than a Valhalla issue. I will create a separate issue to track that.

[hangshao0]

I will create a separate issue to track that.

https://github.com/eclipse-openj9/openj9/issues/15933

[hangshao0]

Seems that there is a merge issue that result in redefinition of unexpectedClasses here: https://github.com/ibmruntimes/openj9-openjdk-jdk.valuetypes/blob/openj9/test/hotspot/jtreg/vmTestbase/nsk/jvmti/ClassPrepare/classprep001/classprep001.cpp#L67-L73

[JasonFengJ9]

redefinition of unexpectedClasses

Note: this is fixed via https://github.com/ibmruntimes/openj9-openjdk-jdk.valuetypes/pull/5