openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

Fix StartContinuationProcessing and verbosegc report issues

Open LinHu2016 opened this issue 2 years ago • 5 comments

  • Remove duplicated StartContinuationProcessing
  • Fix missing MM_CopyForwardStats._continuationCandidates merge

Signed-off-by: Lin Hu [email protected]

LinHu2016 avatar Sep 20 '22 14:09 LinHu2016

@amicic @dmitripivkine please review the changes, Thanks

LinHu2016 avatar Sep 20 '22 14:09 LinHu2016

we do the same thing in MM_ScavengerRootScanner::startProcessing ? we should probably rename it to be more specific like startContinuation(Objects?)Processing

amicic avatar Sep 20 '22 14:09 amicic

we do the same thing in MM_ScavengerRootScanner::startProcessing ? we should probably rename it to be more specific like startContinuation(Objects?)Processing

yes, same thing in MM_ScavengerRootScanner::startProcessing, or Can we merge startUnfinalizedProcessing into MM_ScavengerRootScanner::startProcessing?

LinHu2016 avatar Sep 20 '22 15:09 LinHu2016

Would could merge, but still the point is that startProcessing method needs a bit more specific name, about what kind of processing we start (in that merged case, for example it could be renamed to startClearalbeRootsProcessing). I'd rather keep them separate, since typically for each root or clearable root, we have separate top level methods for any kind of processing.

amicic avatar Sep 20 '22 15:09 amicic

we already have separate methods like:

MM_ScavengerRootClearer::scanContinuationObjects/scavengeContinuationObjects

amicic avatar Sep 20 '22 15:09 amicic

Jenkins test sanity xLinux jdk19

amicic avatar Sep 27 '22 14:09 amicic

jenkins compile win jdk19

amicic avatar Sep 27 '22 14:09 amicic