openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

WIP: Load default value instance if the class is initialized

Open a7ehuo opened this issue 3 years ago • 3 comments
trafficstars

ILGen:

  • aconst_init: Load the default value instance if the class is initialized. This enhancement can be disabled by setting env variable TR_DisableLoadStaticDefaultValueInstance.

SymRef:

  • Create symbol reference for default value instance of value class.

AOT (X86):

  • Add new relocation record TR_RelocationRecordStaticDefaultValueInstance to materialize the default value instance slot address on AOT load.

Depends on

  • [ ] https://github.com/eclipse/omr/pull/6641

Signed-off-by: Annabelle Huo [email protected]

a7ehuo avatar Aug 04 '22 17:08 a7ehuo

This PR has dependency on https://github.com/eclipse/omr/pull/6641 and should be reviewed together with it

a7ehuo avatar Aug 04 '22 18:08 a7ehuo

@dsouzai @hzongaro May I ask you to review this change along with https://github.com/eclipse/omr/pull/6641? Thank you!

a7ehuo avatar Aug 04 '22 18:08 a7ehuo

@hzongaro @dsouzai All comments are addressed. Ready for another review. Thanks!

a7ehuo avatar Aug 08 '22 22:08 a7ehuo

Removed WIP. The OMR dependency https://github.com/eclipse/omr/pull/6641 has been merged to https://github.com/eclipse-openj9/openj9-omr. This PR is ready for another review and PR build test.

a7ehuo avatar Aug 11 '22 14:08 a7ehuo

AOT changes look good to me. @hzongaro do you mind being committer for this one?

dsouzai avatar Aug 11 '22 19:08 dsouzai

Jenkins test sanity all jdk17

hzongaro avatar Aug 11 '22 20:08 hzongaro

@hzongaro For this PR, JDKNext standard and JDKNext valhalla should be tested as well. You probably already plan to do so. Just a reminder

a7ehuo avatar Aug 11 '22 21:08 a7ehuo

Jenkins test sanity,extended xlinuxval jdknext

hzongaro avatar Aug 12 '22 11:08 hzongaro

xlinuxval build failure appears to be unrelated to this pull request.

hzongaro avatar Aug 12 '22 13:08 hzongaro

Jenkins test sanity+aot xlinux jdknext

hzongaro avatar Aug 12 '22 13:08 hzongaro

Jenkins test sanity,extended xlinuxval jdknext

hzongaro avatar Aug 12 '22 16:08 hzongaro