openj9
openj9 copied to clipboard
Add new DDR command constantpool
Fix #15128 @fengxue-IS
@fengxue-IS ready to be reviewed
@keithc-ca can you please review this, thanks @tajila FYI
@keithc-ca can this PR be merged or do you have any additional concern that you would like to see addressed?
I'll have another look shortly.
I might somehow messed up with the branch and I'm trying to get it fixed.
FYI https://github.com/eclipse-openj9/openj9/commit/379aa5af7ee467af7cafb1abed9aa3e1fd3e041d seem to be the snapshot before incorrect merge
FYI 379aa5a seem to be the snapshot before incorrect merge
yeah I pushed the master branch in my java 19 repo without realizing it's not in sync with my java 18 repo which contains the latest changes.
See https://github.com/eclipse-openj9/openj9/issues/15128#issuecomment-1212427171.
See #15128 (comment).
Copying reply from https://github.com/eclipse-openj9/openj9/issues/15128#issuecomment-1212436668
This is expected as when a classfile is loaded by the VM, CP entries will be optimized by the JVM (items reordered : ldc entries moved to the top, long and double moved to the end, UTF8 that do not get referenced directly gets removed from constantpool and referenced via SRPs)
@keithc-ca can you take another look
@keithc-ca Your comments have been addressed
jenkins test sanity alinux64 jdk8,jdk17