openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

Add new DDR command constantpool

Open thallium opened this issue 2 years ago • 10 comments

Fix #15128 @fengxue-IS

thallium avatar Jun 22 '22 20:06 thallium

@fengxue-IS ready to be reviewed

thallium avatar Jul 06 '22 15:07 thallium

@keithc-ca can you please review this, thanks @tajila FYI

fengxue-IS avatar Jul 14 '22 17:07 fengxue-IS

@keithc-ca can this PR be merged or do you have any additional concern that you would like to see addressed?

fengxue-IS avatar Aug 08 '22 19:08 fengxue-IS

I'll have another look shortly.

keithc-ca avatar Aug 09 '22 19:08 keithc-ca

I might somehow messed up with the branch and I'm trying to get it fixed.

thallium avatar Aug 09 '22 20:08 thallium

FYI https://github.com/eclipse-openj9/openj9/commit/379aa5af7ee467af7cafb1abed9aa3e1fd3e041d seem to be the snapshot before incorrect merge

fengxue-IS avatar Aug 09 '22 20:08 fengxue-IS

FYI 379aa5a seem to be the snapshot before incorrect merge

yeah I pushed the master branch in my java 19 repo without realizing it's not in sync with my java 18 repo which contains the latest changes.

thallium avatar Aug 09 '22 20:08 thallium

See https://github.com/eclipse-openj9/openj9/issues/15128#issuecomment-1212427171.

keithc-ca avatar Aug 11 '22 19:08 keithc-ca

See #15128 (comment).

Copying reply from https://github.com/eclipse-openj9/openj9/issues/15128#issuecomment-1212436668

This is expected as when a classfile is loaded by the VM, CP entries will be optimized by the JVM (items reordered : ldc entries moved to the top, long and double moved to the end, UTF8 that do not get referenced directly gets removed from constantpool and referenced via SRPs)

fengxue-IS avatar Aug 21 '22 22:08 fengxue-IS

@keithc-ca can you take another look

fengxue-IS avatar Aug 24 '22 15:08 fengxue-IS

@keithc-ca Your comments have been addressed

thallium avatar Sep 22 '22 13:09 thallium

jenkins test sanity alinux64 jdk8,jdk17

keithc-ca avatar Sep 22 '22 20:09 keithc-ca