openj9 icon indicating copy to clipboard operation
openj9 copied to clipboard

JDK19: Test failures related to OpenJDK Thread and Loom

Open tajila opened this issue 3 years ago • 49 comments

sanity.functional

  • J9vmTest_4
  • J9vmTest_5
  • TestFlushReflectionCache_2
  • jit_jitt_0

extended.functional

  • VmArgumentTests_0
  • TestRefreshGCSpecialClassesCache_BCI_FAST_HCR_2
  • TestRefreshGCSpecialClassesCache_BCI_EXTENDED_HCR_1
  • testDDRExt_Class_0
  • testDDRExtJunit_FindExtThread_0
  • TestRefreshGCSpecialClassesCache_NOBCI_JIT_ON_0

sanity.system

  • MauveSingleInvocLoad_J9_5m_0
  • MauveSingleInvocLoad_J9_5m_1
  • MauveSingleThrdLoad_J9_5m_0
  • MauveSingleThrdLoad_J9_5m_1
  • MauveMultiThrdLoad_5m_0
  • MauveMultiThrdLoad_5m_1

extended.system

  • MiniMix_5m_0
  • MiniMix_5m_1
  • HCRLateAttachWorkload_previewEnabled_1
  • HCRLateAttachWorkload_previewEnabled_0
  • MiniMix_aot_5m_0
  • SharedClasses.SCM23.MultiThread_0

sanity.openjdk (excluded)

  • java/lang/Class/ArrayType.java
  • java/lang/ClassLoader/exeNullCallerClassLoaderTest/NullCallerClassLoaderTest.java
  • java/lang/ClassLoader/BadRegisterAsParallelCapableCaller.java
  • java/lang/System/PropertyTest.java
  • java/lang/Thread/virtual/stress/GetStackTraceALot.java#id0
  • java/lang/Thread/virtual/stress/PinALot.java#id0
  • java/lang/Thread/virtual/stress/PingPong.java
  • java/lang/Thread/virtual/stress/Skynet.java#id0
  • java/lang/Thread/virtual/stress/SleepALot.java#id0
  • java/lang/Thread/virtual/stress/TimedGet.java
  • java/lang/Thread/virtual/stress/YieldALot.java#id0
  • java/lang/Thread/virtual/Collectable.java
  • java/lang/Thread/virtual/CustomScheduler.java
  • java/lang/Thread/virtual/GetStackTraceWhenRunnable.java
  • java/lang/Thread/virtual/HoldsLock.java
  • java/lang/Thread/virtual/Locking.java
  • java/lang/Thread/virtual/Parking.java
  • java/lang/Thread/virtual/ParkWithFixedThreadPool.java
  • java/lang/Thread/virtual/PreviewFeaturesNotEnabled.java
  • java/lang/Thread/virtual/Reflection.java
  • java/lang/Thread/virtual/ShutdownHook.java
  • java/lang/Thread/virtual/StackTraces.java
  • java/lang/Thread/virtual/ThreadAPI.java
  • java/lang/Thread/virtual/ThreadLocals.java
  • java/lang/Thread/virtual/TracePinnedThreads.java
  • java/lang/Thread/virtual/WaitNotify.java
  • java/lang/Thread/BuilderTest.java
  • java/lang/Thread/JoinWithDuration.java
  • java/lang/Thread/SleepWithDuration.java
  • jdk/internal/misc/ThreadFlock/ThreadFlockTest.java
  • jdk/internal/vm/Continuation/Basic.java
  • jdk/internal/vm/Continuation/ClassUnloading.java
  • jdk/internal/vm/Continuation/HumongousStack.java
  • jdk/internal/vm/Continuation/LiveFramesDriver.java
  • jdk/internal/vm/Continuation/Scoped.java
  • java/lang/Class/ArrayType.java
  • java/lang/ClassLoader/exeNullCallerClassLoaderTest/NullCallerClassLoaderTest.java
  • java/lang/ClassLoader/BadRegisterAsParallelCapableCaller.java
  • java/lang/System/PropertyTest.java
  • java/lang/Thread/virtual/stress/GetStackTraceALot.java#id0
  • java/lang/Thread/virtual/stress/PinALot.java#id0
  • java/lang/Thread/virtual/stress/PingPong.java
  • java/lang/Thread/virtual/stress/Skynet.java#id0
  • java/lang/Thread/virtual/stress/SleepALot.java#id0
  • java/lang/Thread/virtual/stress/TimedGet.java
  • java/lang/Thread/virtual/stress/YieldALot.java#id0
  • java/lang/Thread/virtual/Collectable.java
  • java/lang/Thread/virtual/CustomScheduler.java
  • java/lang/Thread/virtual/GetStackTraceWhenRunnable.java
  • java/lang/Thread/virtual/HoldsLock.java
  • java/lang/Thread/virtual/Locking.java
  • java/lang/Thread/virtual/Parking.java
  • java/lang/Thread/virtual/ParkWithFixedThreadPool.java
  • java/lang/Thread/virtual/PreviewFeaturesNotEnabled.java
  • java/lang/Thread/virtual/Reflection.java
  • java/lang/Thread/virtual/ShutdownHook.java
  • java/lang/Thread/virtual/StackTraces.java
  • java/lang/Thread/virtual/ThreadAPI.java
  • java/lang/Thread/virtual/ThreadLocals.java
  • java/lang/Thread/virtual/TracePinnedThreads.java
  • java/lang/Thread/virtual/WaitNotify.java
  • java/lang/Thread/BuilderTest.java
  • java/lang/Thread/JoinWithDuration.java
  • java/lang/Thread/NullStackTrace.java
  • java/lang/Thread/SleepWithDuration.java
  • jdk/internal/misc/ThreadFlock/ThreadFlockTest.java
  • jdk/internal/vm/Continuation/Basic.java
  • jdk/internal/vm/Continuation/ClassUnloading.java
  • jdk/internal/vm/Continuation/HumongousStack.java
  • jdk/internal/vm/Continuation/LiveFramesDriver.java
  • jdk/internal/vm/Continuation/Scoped.java
  • java/util/concurrent/ExecutorService/CloseTest.java
  • java/util/concurrent/tck/JSR166TestCase.java
  • java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java
  • java/util/concurrent/ExecutorService/CloseTest.java
  • java/util/concurrent/tck/JSR166TestCase.java
  • java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java
  • java/util/Map/BasicSerialization.java

extended.openjdk

  • javax/naming/spi/providers/InitialContextTest.java
  • javax/naming/spi/providers/InitialContextTest.java
  • java/nio/channels/vthread/BlockingChannelOps.java
  • java/nio/channels/vthread/BlockingChannelOps.java
  • javax/net/ssl/ServerName/SSLEngineExplorerWithSrv.java
  • javax/net/ssl/SSLEngine/LargePacket.java
  • sun/security/pkcs11/Secmod/AddTrustedCert.java
  • sun/security/pkcs11/Secmod/AddTrustedCert.java
  • javax/net/ssl/SSLEngine/LargePacket.java
  • sun/security/krb5/auto/BasicProc.java
  • sun/security/krb5/auto/BasicProc.java

tajila avatar May 31 '22 14:05 tajila

@fengxue-IS @pshipton Lets put all the Test failures here

tajila avatar May 31 '22 14:05 tajila

Note: any test that relies on Loom support will need to add the --enable-preview support flag. We can disable these tests for the time being

tajila avatar May 31 '22 15:05 tajila

I can look at the test failure(s) if needed.

JasonFengJ9 avatar May 31 '22 15:05 JasonFengJ9

@JasonFengJ9 Since Jack is running sanity.functional can you run sanity.openjdk?

tajila avatar May 31 '22 15:05 tajila

Just add links to failing tests here, Ill update the description

tajila avatar May 31 '22 15:05 tajila

List of known failed testing in sanity.functional

JCL_Test_0

  • JCL_TEST_Java-Lang
  • org.openj9.test.java.lang.Test_Thread.test_start_WeakReference
    org.openj9.test.java.lang.Test_Thread.test_currentThread
    org.openj9.test.java.lang.Test_Thread.test_toString
    
    org.openj9.test.java.lang.Test_ThreadGroup:test_Constructor2 
    org.openj9.test.java.lang.Test_ThreadGroup:test_uncaughtException
    org.openj9.test.java.lang.Test_ThreadGroup:test_destroy3
    org.openj9.test.java.lang.Test_ThreadGroup:test_destroy
    org.openj9.test.java.lang.Test_ThreadGroup:test_activeCount
    org.openj9.test.java.lang.Test_ThreadGroup:test_resume
    org.openj9.test.java.lang.Test_ThreadGroup:test_stop
    org.openj9.test.java.lang.Test_ThreadGroup:test_suspend
    org.openj9.test.java.lang.Test_ThreadGroup:test_remove
    org.openj9.test.java.lang.Test_ThreadGroup:test_destroy2
    org.openj9.test.java.lang.Test_ThreadGroup:test_list
    org.openj9.test.java.lang.Test_ThreadGroup:test_setDaemon2
    

fixed by https://github.com/ibmruntimes/openj9-openjdk-jdk/pull/451: ~~J9vmTest_0~~ ~~J9vmTest_1~~ ~~J9vmTest_2~~ ~~J9vmTest_3~~

J9vmTest_4

  • +++ j9vm.test.invalidclasspath.SetClasspathTest: +++
    command: /root/openj9-openjdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/java  -XX:+UseCompressedOops -Xjit -Xgcpolicy:balanced  -Xdump -Xms64m -Xmx64m -Xshareclasses:name=setclasspathtest,reset,verboseHelper -Xtrace:print={j9jcl.423}    -classpath /root/openj9-openjdk-jdk/openj9/test/TKG/../../jvmtest/functional/VM_Test/VM_Test.jar:/root/openj9-openjdk-jdk/openj9/test/TKG/../TKG/lib/asm-all.jar  j9vm.test.invalidclasspath.SetClasspathTest 
    ...
    Error:: Did not find ROMClass entry for TestA1 in shared cache
    Error:: Did not find ROMClass entry for TestB3 in shared cache
    Error:: Did not find ROMClass entry for TestA4 in shared cache
    Error:: Did not find Orphan entry for TestA2 in shared cache
    Error:: Did not find Orphan entry for TestB1 in shared cache
    Error:: Did not find Orphan entry for TestB2 in shared cache
    Error:: Did not find Orphan entry for TestC1 in shared cache
    Error:: Did not find Orphan entry for TestA3 in shared cache
    *** Test FAILED *** (j9vm.test.invalidclasspath.SetClasspathTest)
    

J9vmTest_5

  • +++ j9vm.test.multipleorphans.InvokeDynamicWithMultipleOrphanComparisonTest: +++
    command: /root/openj9-openjdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/java  -Xcompressedrefs -Xjit -Xgcpolicy:gencon  -Xdump -Xms64m -Xmx64m  -Xshareclasses:enableBCI,name=invokedynamictestcache,reset -Xtrace:print=tpnid{j9bcu.131}   -classpath /root/openj9-openjdk-jdk/openj9/test/TKG/../../jvmtest/functional/VM_Test/VM_Test.jar:/root/openj9-openjdk-jdk/openj9/test/TKG/../TKG/lib/asm-all.jar  j9vm.test.multipleorphans.InvokeDynamicWithMultipleOrphanComparisonTest 
    
    JVMSHRC256I Persistent shared cache "invokedynamictestcache" has been destroyed
    Class file InvokeDynamicTest_458.class is created in dir /root/openj9-openjdk-jdk/openj9/test/TKG/output_1654191082700/J9vmTest_5/multipleorphanstest/j9vm/test/multipleorphans
    Result = 20
    Test Passed
    PASS: pass string found
    
    command: /root/openj9-openjdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/java  -Xcompressedrefs -Xjit - Xgcpolicy:gencon  -Xdump -Xms64m -Xmx64m  -Xshareclasses:enableBCI,name=invokedynamictestcache,printStats=orphan+romclass   -classpath /root/openj9-openjdk-jdk/openj9/test/TKG/../../jvmtest/functional/VM_Test/VM_Test.jar:/root/openj9-openjdk-jdk/openj9/test/TKG/../TKG/lib/asm-all.jar  j9vm.test.multipleorphans.InvokeDynamicWithMultipleOrphanComparisonTest 
    
    JVMSHRC023E Cache does not exist
    no-zero exit value: 1
    FAIL: Did not find ORPHAN entry for class InvokeDynamicTest in the shared class cache
    
    *** Test FAILED *** (j9vm.test.multipleorphans.InvokeDynamicWithMultipleOrphanComparisonTest)
    

~~jvmnativestest_0~~ (fixed)

TestFlushReflectionCache_2

~~ThreadInterruptImplTest_0~~ (fixed by https://github.com/fengxue-IS/openj9/commit/8d19a4fa7879f7ac86481e2413e283e8079a6a2e)

  • ~~test_interruptDuringRun~~
  • ~~test_interruptBeforeAndDuringRun~~

jit_jitt_0

fengxue-IS avatar May 31 '22 15:05 fengxue-IS

@fengxue-IS Since these suites consistent of a number of sub-tests, it would be useful to list, or if there are too many give a number for how many, sub-tests are failing in each of the suites mentioned in the previous comment.

pshipton avatar May 31 '22 15:05 pshipton

Launched a personal build view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/13083 w/ sanity.openjdk at ppc64_aix,x86-64_linux,ppc64le_linux,s390x_linux,aarch64_linux,aarch64_mac,x86-64_windows.

JasonFengJ9 avatar May 31 '22 15:05 JasonFengJ9

sanity.openjdk results w/ https://github.com/eclipse-openj9/openj9/pull/15073:

  • https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdknext_j9_sanity.openjdk_x86-64_linux_Personal/143/consoleFull

56/78 failures happen because of

javanextvmi.c:215: JVM_IsPreviewEnabled: Assertion `!"JVM_IsPreviewEnabled unimplemented"' failed.

The above failures should be resolved with JVM_IsPreviewEnabled's implementation:

 JNIEXPORT jboolean JNICALL
 JVM_IsPreviewEnabled(JNIEnv *env)
 {
-       assert(!"JVM_IsPreviewEnabled unimplemented");
-       return JNI_TRUE;
+       J9VMThread *currentThread = (J9VMThread *)env;
+       return J9_ARE_ANY_BITS_SET(currentThread->javaVM->extendedRuntimeFlags2, J9_EXTENDED_RUNTIME2_ENABLE_PREVIEW);
 }

~@fengxue-IS Would you like to include the above code in https://github.com/eclipse-openj9/openj9/pull/15073?~ It won't help the tests to pass. Because other assertions will be hit next such as the one in JVM_RegisterContinuationMethods and other stubs.

Failing sanity.openjdk Tests

java/lang/Class/ArrayType.java
java/lang/ClassLoader/exeNullCallerClassLoaderTest/NullCallerClassLoaderTest.java
java/lang/ClassLoader/BadRegisterAsParallelCapableCaller.java
java/lang/System/PropertyTest.java
java/lang/Thread/virtual/stress/GetStackTraceALot.java#id0
java/lang/Thread/virtual/stress/PinALot.java#id0
java/lang/Thread/virtual/stress/PingPong.java
java/lang/Thread/virtual/stress/Skynet.java#id0
java/lang/Thread/virtual/stress/SleepALot.java#id0
java/lang/Thread/virtual/stress/TimedGet.java
java/lang/Thread/virtual/stress/YieldALot.java#id0
java/lang/Thread/virtual/Collectable.java
java/lang/Thread/virtual/CustomScheduler.java
java/lang/Thread/virtual/GetStackTraceWhenRunnable.java
java/lang/Thread/virtual/HoldsLock.java
java/lang/Thread/virtual/Locking.java
java/lang/Thread/virtual/Parking.java
java/lang/Thread/virtual/ParkWithFixedThreadPool.java
java/lang/Thread/virtual/PreviewFeaturesNotEnabled.java
java/lang/Thread/virtual/Reflection.java
java/lang/Thread/virtual/ShutdownHook.java
java/lang/Thread/virtual/StackTraces.java
java/lang/Thread/virtual/ThreadAPI.java
java/lang/Thread/virtual/ThreadLocals.java
java/lang/Thread/virtual/TracePinnedThreads.java
java/lang/Thread/virtual/WaitNotify.java
java/lang/Thread/BuilderTest.java
java/lang/Thread/JoinWithDuration.java
java/lang/Thread/SleepWithDuration.java
jdk/internal/misc/ThreadFlock/ThreadFlockTest.java
jdk/internal/vm/Continuation/Basic.java
jdk/internal/vm/Continuation/ClassUnloading.java
jdk/internal/vm/Continuation/HumongousStack.java
jdk/internal/vm/Continuation/LiveFramesDriver.java
jdk/internal/vm/Continuation/Scoped.java
java/lang/Class/ArrayType.java
java/lang/ClassLoader/exeNullCallerClassLoaderTest/NullCallerClassLoaderTest.java
java/lang/ClassLoader/BadRegisterAsParallelCapableCaller.java
java/lang/System/PropertyTest.java
java/lang/Thread/virtual/stress/GetStackTraceALot.java#id0
java/lang/Thread/virtual/stress/PinALot.java#id0
java/lang/Thread/virtual/stress/PingPong.java
java/lang/Thread/virtual/stress/Skynet.java#id0
java/lang/Thread/virtual/stress/SleepALot.java#id0
java/lang/Thread/virtual/stress/TimedGet.java
java/lang/Thread/virtual/stress/YieldALot.java#id0
java/lang/Thread/virtual/Collectable.java
java/lang/Thread/virtual/CustomScheduler.java
java/lang/Thread/virtual/GetStackTraceWhenRunnable.java
java/lang/Thread/virtual/HoldsLock.java
java/lang/Thread/virtual/Locking.java
java/lang/Thread/virtual/Parking.java
java/lang/Thread/virtual/ParkWithFixedThreadPool.java
java/lang/Thread/virtual/PreviewFeaturesNotEnabled.java
java/lang/Thread/virtual/Reflection.java
java/lang/Thread/virtual/ShutdownHook.java
java/lang/Thread/virtual/StackTraces.java
java/lang/Thread/virtual/ThreadAPI.java
java/lang/Thread/virtual/ThreadLocals.java
java/lang/Thread/virtual/TracePinnedThreads.java
java/lang/Thread/virtual/WaitNotify.java
java/lang/Thread/BuilderTest.java
java/lang/Thread/JoinWithDuration.java
java/lang/Thread/NullStackTrace.java
java/lang/Thread/SleepWithDuration.java
jdk/internal/misc/ThreadFlock/ThreadFlockTest.java
jdk/internal/vm/Continuation/Basic.java
jdk/internal/vm/Continuation/ClassUnloading.java
jdk/internal/vm/Continuation/HumongousStack.java
jdk/internal/vm/Continuation/LiveFramesDriver.java
jdk/internal/vm/Continuation/Scoped.java
java/util/concurrent/ExecutorService/CloseTest.java
java/util/concurrent/tck/JSR166TestCase.java
java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java
java/util/concurrent/ExecutorService/CloseTest.java
java/util/concurrent/tck/JSR166TestCase.java
java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java
java/util/Map/BasicSerialization.java

babsingh avatar Jun 01 '22 00:06 babsingh

sanity.system results w/ https://github.com/eclipse-openj9/openj9/pull/15073:

  • https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdkNext_j9_sanity.system_x86-64_linux_Personal/144/tapResults/

Failing sanity.system Test Targets

MauveSingleInvocLoad_J9_5m_0
MauveSingleInvocLoad_J9_5m_1
MauveSingleThrdLoad_J9_5m_0
MauveSingleThrdLoad_J9_5m_1
MauveMultiThrdLoad_5m_0
MauveMultiThrdLoad_5m_1

Errors

Some of the below errors may get fixed with https://github.com/fengxue-IS/openj9/commit/8d19a4fa7879f7ac86481e2413e283e8079a6a2e.

LT  FAIL: gnu.testlet.java.lang.Thread.interrupt: InterruptedException in wait() clears interrupt flag (number 0)
LT  FAIL: gnu.testlet.java.lang.Thread.interrupt: InterruptedException in sleep() clears interrupt flag (number 0)
LT  FAIL: gnu.testlet.java.lang.Thread.interrupt: InterruptedException in join() clears interrupt flag (number 0)

babsingh avatar Jun 01 '22 00:06 babsingh

extended.system results w/ https://github.com/eclipse-openj9/openj9/pull/15073:

  • https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdkNext_j9_extended.system_x86-64_linux_Personal/138/tapResults/

Failing extended.system Test Targets

MiniMix_5m_0
MiniMix_5m_1
HCRLateAttachWorkload_previewEnabled_1 
HCRLateAttachWorkload_previewEnabled_0
MiniMix_aot_5m_0
SharedClasses.SCM23.MultiThread_0

Errors

Some of the below errors may get fixed with https://github.com/fengxue-IS/openj9/commit/8d19a4fa7879f7ac86481e2413e283e8079a6a2e.

LT  FAIL: gnu.testlet.java.lang.Thread.interrupt: InterruptedException in wait() clears interrupt flag (number 0)
LT  FAIL: gnu.testlet.java.lang.Thread.interrupt: InterruptedException in sleep() clears interrupt flag (number 0)
LT  FAIL: gnu.testlet.java.lang.Thread.interrupt: InterruptedException in join() clears interrupt flag (number 0)

babsingh avatar Jun 01 '22 01:06 babsingh

extended.functional results w/ https://github.com/eclipse-openj9/openj9/pull/15073:

  • https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdkNext_j9_extended.functional_x86-64_linux_Personal/194/tapResults/

Failing extended.functional Test Targets

VmArgumentTests_0
TestRefreshGCSpecialClassesCache_BCI_FAST_HCR_2
TestRefreshGCSpecialClassesCache_BCI_EXTENDED_HCR_1
testDDRExt_Class_0
testDDRExtJunit_FindExtThread_0
TestRefreshGCSpecialClassesCache_NOBCI_JIT_ON_0

babsingh avatar Jun 01 '22 01:06 babsingh

extended.openjdk results w/ https://github.com/eclipse-openj9/openj9/pull/15073:

  • https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdknext_j9_extended.openjdk_x86-64_linux_Personal/1/consoleFull

Failing extended.openjdk Tests

javax/naming/spi/providers/InitialContextTest.java
javax/naming/spi/providers/InitialContextTest.java
java/nio/channels/vthread/BlockingChannelOps.java
java/nio/channels/vthread/BlockingChannelOps.java
javax/net/ssl/ServerName/SSLEngineExplorerWithSrv.java
javax/net/ssl/SSLEngine/LargePacket.java
sun/security/pkcs11/Secmod/AddTrustedCert.java
sun/security/pkcs11/Secmod/AddTrustedCert.java
javax/net/ssl/SSLEngine/LargePacket.java
sun/security/krb5/auto/BasicProc.java
sun/security/krb5/auto/BasicProc.java

babsingh avatar Jun 01 '22 01:06 babsingh

Summary

  • sanity.functional: https://github.com/eclipse-openj9/openj9/issues/15152#issuecomment-1142275103
  • extended.functional: https://github.com/eclipse-openj9/openj9/issues/15152#issuecomment-1142996246
  • sanity.openjdk: https://github.com/eclipse-openj9/openj9/issues/15152#issuecomment-1142865822
  • extended.openjdk: https://github.com/eclipse-openj9/openj9/issues/15152#issuecomment-1143015535
  • sanity.system: https://github.com/eclipse-openj9/openj9/issues/15152#issuecomment-1142929366
  • extended.system: https://github.com/eclipse-openj9/openj9/issues/15152#issuecomment-1142949996

babsingh avatar Jun 01 '22 01:06 babsingh

Excluding following sanity.openjdk tests:

java/lang/annotation/UnitTest.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Class/ArrayType.java	https://github.com/eclipse-openj9/openj9/issues/15167	generic-all
java/lang/ClassLoader/BadRegisterAsParallelCapableCaller.java	https://github.com/eclipse-openj9/openj9/issues/15168	generic-all
java/lang/ClassLoader/exeNullCallerClassLoaderTest/NullCallerClassLoaderTest.java	https://github.com/eclipse-openj9/openj9/issues/15168	generic-all
java/lang/System/PropertyTest.java	https://github.com/eclipse-openj9/openj9/issues/15129	generic-all
java/lang/Thread/virtual/stress/GetStackTraceALot.java#id0	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/stress/PinALot.java#id0	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/stress/PingPong.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/stress/Skynet.java#id0	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/stress/SleepALot.java#id0	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/stress/TimedGet.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/Collectable.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/stress/YieldALot.java#id0	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/CustomScheduler.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/GetStackTraceWhenRunnable.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/HoldsLock.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/Parking.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/Locking.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/PreviewFeaturesNotEnabled.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/Reflection.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/ParkWithFixedThreadPool.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/StackTraces.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/ThreadAPI.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/ShutdownHook.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/TracePinnedThreads.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/ThreadLocals.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/virtual/WaitNotify.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/BuilderTest.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/JoinWithDuration.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/Thread/SleepWithDuration.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/ThreadLocal/TestThreadId.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/lang/invoke/defineHiddenClass/PreviewHiddenClass.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
jdk/internal/misc/ThreadFlock/ThreadFlockTest.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
jdk/internal/vm/Continuation/Basic.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
jdk/internal/vm/Continuation/HumongousStack.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
jdk/internal/vm/Continuation/Scoped.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
jdk/internal/vm/Continuation/LiveFramesDriver.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
jdk/internal/vm/Continuation/ClassUnloading.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
jdk/modules/etc/DefaultModules.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/util/concurrent/ExecutorService/CloseTest.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/util/concurrent/tck/JSR166TestCase.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/util/concurrent/ThreadPerTaskExecutor/ThreadPerTaskExecutorTest.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all

JasonFengJ9 avatar Jun 01 '22 12:06 JasonFengJ9

[test excluded]

Running a personal build to verify the change, not submitted yet.

JasonFengJ9 avatar Jun 01 '22 13:06 JasonFengJ9

Thanks @babsingh for doing the test runs. Ive updated the description above.

@JasonFengJ9 Anything that fails due to --enable-preview can be excluded for now. Any other other failure that we have a fix in hand for can also be excluded, we can re-enable after https://github.com/eclipse-openj9/openj9/pull/15073 is merged.

tajila avatar Jun 01 '22 13:06 tajila

Not sure how close we are to fully pass sanity.functional in https://github.com/eclipse-openj9/openj9/pull/15073. If not very close, can we disable all failing tests (with trackers/issues open)? This will at-least allow builds to promote and changes to move from the openj9-staging to openj9 in the extensions repo. Without latest changes from the extension repo, all other JEP related work will be blocked i.e. can't be merged.

babsingh avatar Jun 01 '22 13:06 babsingh

Anything that fails due to --enable-preview can be excluded for now. Any other other failure that we have a fix in hand for can also be excluded, we can re-enable after https://github.com/eclipse-openj9/openj9/pull/15073 is merged.

Yeah, that's what https://github.com/eclipse-openj9/openj9/issues/15152#issuecomment-1143564328 aims for a green sanity.openjdk. Just echo @babsingh https://github.com/eclipse-openj9/openj9/issues/15152#issuecomment-1143644021, a green sanity.functional w/ excludes can promote openj9-staging content, and help discovering other breakages earlier.

JasonFengJ9 avatar Jun 01 '22 14:06 JasonFengJ9

sanity.openjdk Add JDK19 loom related and other test excludes has been merged.

JasonFengJ9 avatar Jun 02 '22 13:06 JasonFengJ9

Thanks @JasonFengJ9 can you add excludes for extended.openjdk as well?

tajila avatar Jun 02 '22 13:06 tajila

Opened https://github.com/ibmruntimes/openj9-openjdk-jdk/pull/451 to fix some of the test hang issue

fengxue-IS avatar Jun 02 '22 17:06 fengxue-IS

J9vmTest_4 and J9vmTest_5 passed for me

tajila avatar Jun 03 '22 14:06 tajila

I was able to pass all the tests in VM_Test, but I built my JVM without optimizations. Ill try a regular build

tajila avatar Jun 03 '22 18:06 tajila

Created PR to exclude extended.openjdk failures:

java/nio/channels/etc/AdaptorCloseAndInterrupt.java	https://github.com/eclipse-openj9/openj9/issues/15152	generic-all
java/security/misc/Versions.java	https://github.com/eclipse-openj9/openj9/issues/15206	generic-all
sun/security/util/Resources/Usages.java	https://github.com/eclipse-openj9/openj9/issues/15209	generic-all
javax/naming/spi/providers/InitialContextTest.java	https://github.com/eclipse-openj9/openj9/issues/15205	generic-all
jdk/incubator/vector/Vector128ConversionTests.java	https://github.com/eclipse-openj9/openj9/issues/15211	generic-all

JasonFengJ9 avatar Jun 03 '22 19:06 JasonFengJ9

I was able to pass these with Jack's Thread.stop() changes

TEST TARGETS SUMMARY
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
PASSED test targets:
	J9vmTest_0
	J9vmTest_1
	J9vmTest_2
	J9vmTest_3
	J9vmTest_4
	J9vmTest_5
	jvmnativestest_0
	SharedClassesSysVTesting_0

TOTAL: 8   EXECUTED: 8   PASSED: 8   FAILED: 0   DISABLED: 0   SKIPPED: 0
ALL TESTS PASSED

Can someone else confirm this

tajila avatar Jun 03 '22 20:06 tajila

TEST TARGETS SUMMARY ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ PASSED test targets: J9vmTest_0 J9vmTest_1 J9vmTest_2 J9vmTest_3 J9vmTest_4 J9vmTest_5 jvmnativestest_0 SharedClassesSysVTesting_0 TOTAL: 8 EXECUTED: 8 PASSED: 8 FAILED: 0 DISABLED: 0 SKIPPED: 0 ALL TESTS PASSED Can someone else confirm this

Will give this a run. sanity.functional on ppc64_aix,x86-64_linux,ppc64le_linux,s390x_linux,aarch64_linux,x86-64_mac,x86-64_windows - view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/13113/ - the personal build failed, will attempt manual run.

JasonFengJ9 avatar Jun 03 '22 20:06 JasonFengJ9

Since https://github.com/eclipse-openj9/openj9/pull/15073 is merged, we can't build jdk19 without the openj9-staging branch. Although testing on this branch doesn't work very well, we might as well promote it as long as it continues to compile. @tajila does that work for you?

I ran an acceptance build with sanity.functional but it hangs in sanity.functional in JCL_Test mostly. In jit_jitt_openj9_none_SCC jit_jitt_openj9_none_SCC on xlinux. Windows died running cmdLineTester_GCRegressionTests in "Unload lots of classes using normal behaviour (JIT Disabled)" with OOMs. https://openj9-jenkins.osuosl.org/job/Pipeline-OpenJDK-Acceptance/304/

This JCL_Test hang has more diagnostic output than the others. https://openj9-jenkins.osuosl.org/job/Test_openjdknext_j9_sanity.functional_aarch64_linux_OpenJDK_testList_1/112

02:41:13  org.openj9.test.java.lang.
02:41:14  Exception in thread "Thread-5" java.lang.NullPointerException: Cannot invoke "java.util.function.Predicate.test(java.lang.Object)" because "this.this$1.val$predicate" is null
02:41:14  	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178) from jrt:/java.base
02:41:14  	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1006) from jrt:/java.base
02:41:14  	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:522) from jrt:/java.base
02:41:14  	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:512) from jrt:/java.base
02:41:14  	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:588) from jrt:/java.base
02:41:14  	at java.base/java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:265) from jrt:/java.base
02:41:14  	at java.base/java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:616) from jrt:/java.base
02:41:14  	at java.base/java.lang.Thread.getAllThreads(Thread.java:2698) from jrt:/java.base
02:41:14  	at java.base/java.lang.ThreadGroup.activeCount(ThreadGroup.java:377) from jrt:/java.base
02:41:14  	at org.openj9.test.java.lang.Test_ThreadGroup$4.run(Test_ThreadGroup.java:381) from jdk.internal.loader.ClassLoaders$AppClassLoader@6d2e43e8(file:/home/jenkins/workspace/Test_openjdknext_j9_sanity.functional_aarch64_linux_OpenJDK_testList_1/jvmtest/functional/Java8andUp/GeneralTest.jar)
02:41:14  	at java.base/java.lang.Thread.run(Thread.java:1566) from jrt:/java.base

pshipton avatar Jun 06 '22 12:06 pshipton

Update to the previous comment. In some cases more output occurred when I stopped the hanging tests.

pshipton avatar Jun 06 '22 12:06 pshipton