opendut icon indicating copy to clipboard operation
opendut copied to clipboard

MQTT for monitoring

Open mbfm opened this issue 1 year ago • 1 comments

mbfm avatar May 22 '24 11:05 mbfm

Hey @eet1mu3, I've opened a draft PR for you, to make it easier to track that work is happening on this branch and to have a place to discuss it.

Two points I wanted to point out right away:

  • You rebased onto the main-branch, but in our current workflow, you'd want to rebase onto development instead. We merge all PRs onto development and when we feel like it's somewhat stabilized, we then merge from development onto main and create a release for it.

  • And you merged issue-171-revised into your branch. That's a stale branch. We've continued developing here: https://github.com/eclipse-opendut/opendut/pull/225
    Basically, we had to transfer the work to two colleagues, who don't yet have commit permissions, so couldn't continue work on that branch. We hope to merge that PR into development in the coming days. The code, that you integrated with, didn't change much since that branch got abandoned, so hopefully you won't see too many changes, but yeah, just a heads-up that you might see breakages with the way you had merged things.

mbfm avatar May 22 '24 11:05 mbfm