opendut icon indicating copy to clipboard operation
opendut copied to clipboard

CAN integration

Open reimarstier opened this issue 1 year ago • 3 comments

As soon as the CAN support (#85) has landed, there is further work to be done:

  • [ ] #320
  • [x] #128
  • CAN health check (ping?), round trip time
  • [ ] Address assumption in code: Any interface containing can* is a CAN interface → This is now handled via a separate flag.
  • [ ] Make CAN/ETH optional (e.g. peer with only CAN interface or peer with only car Ethernet interface) → partially covered by #251

@mbfm @hafklin Feel free to modify/add what you have on your mind

reimarstier avatar Feb 27 '24 02:02 reimarstier

Thanks for collecting the TODOs here. Two more things that need to be done:

  • [x] Currently, the port on which cannelloni listens on the leading EDGAR is derived from the client IP address. This may in some cases lead to port collisions and should be handled properly by having CARL assign the ports to the EDGARs. (done: #129)
  • [x] Currently, it is assumed that all physical CAN devices to be used with an EDGAR are already configured (bitrate etc.) and up. However, it may be desirable to allow the user to specify these configuration parameters via LEA/CLEO and have EDGAR configure the CAN devices itself. (done: #276)

CAN health check (ping?), round trip time

@reimarstier where would you like to see this? A basic version of this already exists here and is executed within the test environment.

hafklin avatar Feb 27 '24 07:02 hafklin

Regarding the health check, I was thinking about EDGAR performing this action regularly. This does not exist yet and is not restricted to CAN.

reimarstier avatar Feb 28 '24 11:02 reimarstier

See also #164

mirenz1 avatar Aug 28 '24 09:08 mirenz1