lsp4j icon indicating copy to clipboard operation
lsp4j copied to clipboard

update guava and gson

Open cdietrich opened this issue 10 months ago • 4 comments

cdietrich avatar Feb 12 '25 13:02 cdietrich

I assume this update isn't needed for 2025-03?

jonahgraham avatar Feb 13 '25 02:02 jonahgraham

Depends on how many gsons we want to end up in simrel

cdietrich avatar Feb 13 '25 03:02 cdietrich

lets see what m3 will show.

cdietrich avatar Feb 14 '25 05:02 cdietrich

SimRel continues to be ok, we may want to tighten up the version constraints in https://github.com/eclipse-lsp4j/lsp4j/blob/main/gradle/versions.gradle (raise lower bounds to what is in SimRel 2025-12), but I don't seem much advantage to that as it doesn't change what happens in SimRel and

but it only affects what we build and publish, it doesn't change our dependencies so won't affect what is in SimRel.

:point_up: was incomplete, it only affects what we build and publish in the maven step. It doesn't even affect what we build and test with gradle, which is auto-selected as highest available in maven central that satisfies our version ranges. (In fact I don't quite understand how gradle chooses version to use, because on my machine I see it using guava 33.4.8 instead of 33.5 - do we have a problem with 33.5?) I don't think guava version matters as it affects only generator these days (IIRC)

I recommend closing this PR for now, and if desired I can make a new PR that raises lower bounds.

jonahgraham avatar Nov 19 '25 18:11 jonahgraham