lsp4j icon indicating copy to clipboard operation
lsp4j copied to clipboard

Add nullability annotations

Open NickAcPT opened this issue 3 years ago • 1 comments

Several methods and are missing nullability annotations (@NonNull or @Nullable).

This results in a poor experience in languages like Kotlin because method arguments and return types do not contain the correct nullable or non-null types.

NickAcPT avatar Dec 31 '21 05:12 NickAcPT

Hi @NickAcPT - I would be happy to review/merge a pull request that added such annotations. It may be best to do a single file first to make sure we are all on the same page. For example, the @NonNull annotation in the code today is org.eclipse.lsp4j.jsonrpc.validation.NonNull which may not be what you expect?

jonahgraham avatar Jan 10 '22 21:01 jonahgraham