leshan
leshan copied to clipboard
Add redis support to OSCORE
I added redis serializer/deserializer to allow use OSCORE.
I didn't look at the code but not sure having this kind of git tree is a good idea ?
Is there any reason about this ?
I'm not sure working on RedisSecurityStore is a good idea while we don't define a clear API :
- removing static design : https://github.com/eclipse/leshan/pull/1180#issuecomment-1007524953
- and a clean oscoreStore : https://github.com/eclipse/leshan/issues/920#issuecomment-988722923
I didn't look at the code but not sure having this kind of git tree is a good idea ?
Do you mean about merging opl/oscore_work ? I borrowed some code from opl/oscore_work (which wasn't be intended to be pushed as PR) and looks what it looks like. If it would be finally squashed it shouldn't be a problem I think.
I'm not sure working on RedisSecurityStore is a good idea while we don't define a clear API
You're right. But in current PR I mostly fixed the redis tests which are broken in PR #1180.
Regarding plan at https://github.com/eclipse/leshan/issues/725#issuecomment-1007560037 This is rather tasks corresponding to cleaning and add redis support. So maybe we can postpone it.
But in current PR I mostly fixed the redis tests which are broken in PR #1180.
Yep but maybe https://github.com/eclipse/leshan/pull/1180#issuecomment-1007516874, Is enough in a first time ?
What do you think ?
Yep but maybe #1180 (comment), Is enough in a first time ?
I fixed the tests because I didn't think we can add @Ignore
. So we can postpone current PR :smile: