leshan icon indicating copy to clipboard operation
leshan copied to clipboard

Add redis support to OSCORE

Open Michal-Wadowski opened this issue 3 years ago • 5 comments

I added redis serializer/deserializer to allow use OSCORE.

Michal-Wadowski avatar Dec 22 '21 11:12 Michal-Wadowski

I didn't look at the code but not sure having this kind of git tree is a good idea ?

Capture d’écran de 2022-01-07 15-09-51

Is there any reason about this ?

sbernard31 avatar Jan 07 '22 14:01 sbernard31

I'm not sure working on RedisSecurityStore is a good idea while we don't define a clear API :

  • removing static design : https://github.com/eclipse/leshan/pull/1180#issuecomment-1007524953
  • and a clean oscoreStore : https://github.com/eclipse/leshan/issues/920#issuecomment-988722923

sbernard31 avatar Jan 07 '22 16:01 sbernard31

I didn't look at the code but not sure having this kind of git tree is a good idea ?

Do you mean about merging opl/oscore_work ? I borrowed some code from opl/oscore_work (which wasn't be intended to be pushed as PR) and looks what it looks like. If it would be finally squashed it shouldn't be a problem I think.

I'm not sure working on RedisSecurityStore is a good idea while we don't define a clear API

You're right. But in current PR I mostly fixed the redis tests which are broken in PR #1180.

Michal-Wadowski avatar Jan 10 '22 07:01 Michal-Wadowski

Regarding plan at https://github.com/eclipse/leshan/issues/725#issuecomment-1007560037 This is rather tasks corresponding to cleaning and add redis support. So maybe we can postpone it.

But in current PR I mostly fixed the redis tests which are broken in PR #1180.

Yep but maybe https://github.com/eclipse/leshan/pull/1180#issuecomment-1007516874, Is enough in a first time ?

What do you think ?

sbernard31 avatar Jan 10 '22 10:01 sbernard31

Yep but maybe #1180 (comment), Is enough in a first time ?

I fixed the tests because I didn't think we can add @Ignore. So we can postpone current PR :smile:

Michal-Wadowski avatar Jan 10 '22 11:01 Michal-Wadowski