langium icon indicating copy to clipboard operation
langium copied to clipboard

Domainmodel example: Renaming with qualified name does not work

Open spoenemann opened this issue 4 years ago • 6 comments

Langium version: #275 Package name: langium

Steps To Reproduce

  1. Open datatypes.dmodel
  2. Select Date
  3. Press F2
  4. Enter a new name

The current behavior

The datatype name is changed in blog.dmodel, but it loses the complex. prefix.

The expected behavior

The new name should include the package name.

spoenemann avatar Nov 01 '21 12:11 spoenemann

@spoenemann Should supporting renaming of a package e.g. complex also be a part of this issue?

dhuebner avatar Mar 02 '22 14:03 dhuebner

What is also strange, you can exec Rename Symbol for every QName CSTNode part, which doesn't make much sense: Bildschirmfoto 2022-03-02 um 15 28 53 Bildschirmfoto 2022-03-02 um 15 28 23 Bildschirmfoto 2022-03-02 um 15 28 12

Every such a rename request will end up in rename service with a selected QName part (comlex or . or Date) as newText

dhuebner avatar Mar 02 '22 14:03 dhuebner

Should supporting renaming of a package e.g. complex also be a part of this issue?

Ideally yes (needs special handling to rename all references to contained classes).

What is also strange, you can exec Rename Symbol for every QName CSTNode part, which doesn't make much sense

That seems to be a client side behavior. Don't know what we can do to fix it.

spoenemann avatar Mar 02 '22 17:03 spoenemann

The issue seems to be no longer present. I cannot reproduce with current main state.

insafuhrmann avatar Sep 08 '22 16:09 insafuhrmann

?? I can still reproduce following the steps described at the top.

spoenemann avatar Sep 09 '22 07:09 spoenemann

Yes, today I also can (with today's state of main). Not clear why it worked yesterday for me on the main branch. However, I'll update the fix.

insafuhrmann avatar Sep 09 '22 14:09 insafuhrmann