langium icon indicating copy to clipboard operation
langium copied to clipboard

add implicit ID rule call for cross refs to getAllReachableRules

Open cdietrich opened this issue 2 years ago • 4 comments

add implicit ID rule call for cross refs to getAllReachableRules Fixes #1151

cdietrich avatar Aug 15 '23 15:08 cdietrich

is the build fail related to my changes? do we need to reserve sorting?

cdietrich avatar Aug 16 '23 13:08 cdietrich

@cdietrich Yes, the errors are related to your changes. The order of terminals is very important for the Chevrotain lexer, which is why it needs to be preserved.

msujew avatar Aug 16 '23 13:08 msujew

what do i need to execute to replicate the github action build locally? (so that i can try locally without pushing) where is the rules from imported rules sorted in? at the end?

cdietrich avatar Aug 16 '23 13:08 cdietrich

You just need to run npm test to run the test that the Actions suite is running.

where is the rules from imported rules sorted in? at the end?

Yes, local rules have priority over imported rules. They should be at the end.

msujew avatar Aug 16 '23 13:08 msujew