jkube

jkube copied to clipboard

WatchServiceTest is failing on Windows

10

### Component JKube Kit ### Task description ### Description _Originally posted by @Sintivrousai in [Gitter Thread](https://matrix.to/#/!QryyIuhARjRcebsrTd:gitter.im/$VDpQ2eEsvL4MwV0oUokloNBu1kOle8O3W8pb4rxD96E?via=gitter.im&via=matrix.org&via=jurr.org)_ It looks like WatchServiceTest is failing on Windows again. We had merged a fix...

rohanKanojia

[OpenShift Maven Plugin] : Move duplicated methods in Mojos to a common interface

2

### Component OpenShift Maven Plugin ### Task description ### Description When I check all [Mojo classes in openshift-maven-plugin](https://github.com/eclipse-jkube/jkube/blob/master/openshift-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/) module, I see this method duplicated in every Mojo class: https://github.com/eclipse-jkube/jkube/blob/d25c6769d1f7b7426d84499238e1fd08623f46bc/openshift-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/build/OpenshiftBuildMojo.java#L105 We...

rohanKanojia

`KubernetesHelperTest.exportKubernetesClientConfigToFile_worksWithKubernetesMockServer` is failing on windows

1

### Component JKube Kit ### Task description ### Description This test is failing on Windows at this line https://github.com/eclipse-jkube/jkube/blob/8435d6b22bb1cbcc25c8576c308cc9efb7106363/jkube-kit/common/src/test/java/org/eclipse/jkube/kit/common/util/KubernetesHelperTest.java#L491 ``` Error: Failures: Error: KubernetesHelperTest.exportKubernetesClientConfigToFile_worksWithKubernetesMockServer:479 Multiple Failures (1 failure) -- failure...

rohanKanojia

Replace deprecated method from Updatable interface

2

### Component None ### Task description ### Description Method `Updatable.replace` is used in several places in the project. However, the method is deprecated, and Javadoc advises using the method `update`...

arman-yekkehkhani

### Description The call to `String.length` can be replaced with `isEmpty` in [DockerFileBuilderTest](https://github.com/eclipse-jkube/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/config/image/src/test/java/org/eclipse/jkube/kit/config/image/build/DockerFileBuilderTest.java). The following line: https://github.com/eclipse-jkube/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/config/image/src/test/java/org/eclipse/jkube/kit/config/image/build/DockerFileBuilderTest.java#L288 should be changed to: ```java if (line.trim().isEmpty()) { ``` ### :red_circle: Before you...

manusa

### Description The call to `String.length` can be replaced with `isEmpty` in [CommandLine](https://github.com/eclipse-jkube/jkube/blob/5ca316e5dee6bab961d2d1aa72f99d33d067938a/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/CommandLine.java). The following line: https://github.com/eclipse-jkube/jkube/blob/5ca316e5dee6bab961d2d1aa72f99d33d067938a/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/CommandLine.java#L28 should be changed to: ```java if (toProcess == null || toProcess.isEmpty()) { ```...

manusa

### Description The call to `String.length` can be replaced with `isEmpty` in [BuildService](https://github.com/eclipse-jkube/jkube/blob/9dee5b047481246be704a0408f71fc917fc0ac6c/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/BuildService.java). The following line: https://github.com/eclipse-jkube/jkube/blob/9dee5b047481246be704a0408f71fc917fc0ac6c/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/BuildService.java#L219 should be changed to: ```java return nocache.isEmpty() || Boolean.parseBoolean(nocache); ``` ### :red_circle: Before...

manusa

### Description The call to `Map.size` can be replaced with `isEmpty` in [BuildOptions](https://github.com/eclipse-jkube/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/access/BuildOptions.java). The following line: https://github.com/eclipse-jkube/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/access/BuildOptions.java#L72 should be changed to: ```java if (buildArgs != null && !buildArgs.isEmpty()) { ```...

manusa

feat (jkube-kit/helm) : HelmService exposes helm install functionality

2

## Description Related to #2663 + Add new method `prepareMockWebServerExpectationsForAggregatedDiscoveryEndpoints` in KubernetesMockServerUtil for adding manual expectations for Kubernetes Aggregated Discovery endpoints + Added a new `install` method in HelmService that...

rohanKanojia

oc:build on openshift use pods/log to retrieve logs from build

20

Hello support, We running the openshift-maven-plugin against our openshift cluster to build images. The build its self works and pushes to artifactory without any errors. But we got this message,...

sbollwe