jkube icon indicating copy to clipboard operation
jkube copied to clipboard

DebugService: Unused import 'import org.eclipse.jkube.kit.config.image.build.JKubeBuildStrategy;'

Open manusa opened this issue 1 year ago • 6 comments

Description

The class DebugService presents the issue: Unused import 'import org.eclipse.jkube.kit.config.image.build.JKubeBuildStrategy;'.

The following line: https://github.com/eclipse-jkube/jkube/blob/f5bfbe963d9d77fc89ddfddcb4a803351430ad35/jkube-kit/config/service/src/main/java/org/eclipse/jkube/kit/config/service/DebugService.java#L32 should be removed.

:red_circle: Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down:

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

manusa avatar Sep 18 '24 10:09 manusa

Hi @manusa,

I apologize for the confusion. This issue had been open for the last two weeks, and since no one was working on it, I thought I’d give it a try. Additionally, my friend was interested in learning how to contribute, so I demonstrated the process to him. He wasn’t familiar with how to create a PR, which is why this happened.

I assure you this won’t happen again, and I appreciate your understanding.

Best regards, Shivam

ShivamChavan01 avatar Oct 03 '24 18:10 ShivamChavan01

@ShivamChavan01 : It's okay, you can close this PR and let your friend create it. Ask him to comment on the issue so that we can assign the issue to him.

rohanKanojia avatar Oct 03 '24 18:10 rohanKanojia

can i do it @rohanKanojia ??

Vishwas2001 avatar Oct 04 '24 05:10 Vishwas2001

assign me this, i'll do this "hacktoberfest accepted"

NavikaAgarwal avatar Oct 12 '24 05:10 NavikaAgarwal

@Vishwas2001 : Hello Are you still working on this issue?

rohanKanojia avatar Oct 12 '24 05:10 rohanKanojia

would like to do this issue as my first contribution @rohanKanojia

shree-crypto avatar Oct 12 '24 21:10 shree-crypto

Fixed by #3505

manusa avatar Nov 06 '24 11:11 manusa