jkube icon indicating copy to clipboard operation
jkube copied to clipboard

ImageChangeTriggerEnricher 'containerToImageMap.size() != 0' can be replaced with '!containerToImageMap.isEmpty()'

Open manusa opened this issue 1 year ago • 3 comments

Description

The call to Map.size can be replaced with isEmpty in ImageChangeTriggerEnricher.

The following line:

https://github.com/eclipse-jkube/jkube/blob/8aea35928d3f3157ffcfbd645001adfe4302bbb8/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/ImageChangeTriggerEnricher.java#L82

should be changed to:

                if (!containerToImageMap.isEmpty()) {

:red_circle: Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down:

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

manusa avatar Jun 26 '24 11:06 manusa

Hi @manusa KINDLY ASSIGN THIS TO ME.....

YAKSH22WEBSITEHACKERS avatar Jun 26 '24 17:06 YAKSH22WEBSITEHACKERS

Hello @manusa can you assign this to me if not resolved yet? I can give it a try

OrneyVortex avatar Jul 02 '24 20:07 OrneyVortex

Hi @OrneyVortex, let's ask the current assignee first. We usually give 1-2 weeks margin to complete the issue. Note that there are still plenty open and unassigned first-timers-only issues https://github.com/eclipse-jkube/jkube/labels/first-timers-only (especially at the bottom of the list). Hi @YAKSH22WEBSITEHACKERS, are you working on this?

manusa avatar Jul 03 '24 05:07 manusa

may i pick this up?

vijaybhagwat24 avatar Jul 21 '24 18:07 vijaybhagwat24

@YAKSH22WEBSITEHACKERS : Unassigning you from the issue as there hasn't been any update since past 1 month

rohanKanojia avatar Jul 22 '24 04:07 rohanKanojia