jkube icon indicating copy to clipboard operation
jkube copied to clipboard

HelmLintMojoTest.setUp The declared Exception exception is never thrown

Open manusa opened this issue 9 months ago • 2 comments

Description

The method HelmLintMojoTest.setUp declares an Exception that is never thrown.

The following line https://github.com/eclipse-jkube/jkube/blob/b54dddcbbe8f1083e428f0f65835a1d5441b2df4/kubernetes-maven-plugin/plugin/src/test/java/org/eclipse/jkube/maven/plugin/mojo/build/HelmLintMojoTest.java#L43

  • [ ] should be changed to:
  void setUp() {

Before you start :red_circle:

:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down::point_down::point_down::point_down::point_down::point_down::point_down: Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console. (Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

manusa avatar May 15 '24 14:05 manusa