jkube
jkube copied to clipboard
eclipse-jkube
Fix wrong resources directory path
Description
Fixes #2832
This PR brings the bug fix of wrong resources directory path. URLClassLoader instance was unable to find out neither application.yml nor application.properties resources files due to wrong URLs paths defined.
Method findResource searches for resources files among URLs list, however URL was baseDir + /target/classes, which was given by jKubeProject.getOutputDirectory().getAbsolutePath() call.
I decided to add separate field for resources dir in the JavaProject class and add another jKubeProject.getResourcesDirectory().getAbsolutePath() call to get the right resources path, which should be baseDir + /src/main/resources
Type of change
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change
- [ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)
Checklist
- [X] I have read the contributing guidelines
- [X] I signed-off my commit with a user that has signed the Eclipse Contributor Agreement
- [X] My code follows the style guidelines of this project
- [X] I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
- [X] I use conventional commits in my commit messages
- [X] I have performed a self-review of my code
- [ ] I Added CHANGELOG entry
- [ ] I have updated the documentation accordingly
- [X] No new bugs, code smells, etc. in SonarCloud report
- [X] I have added tests that prove my fix is effective or that my feature works
- [X] New and existing unit tests pass locally with my changes
- [X] I tested my code in Kubernetes
- [ ] I tested my code in OpenShift
Eclipse JKube CI Report
Started new GH workflow run for https://github.com/eclipse-jkube/jkube/pull/2880 (2024-10-21T11:28:46Z)
:gear: JKube E2E Tests (11438752360)
- :heavy_check_mark: Bootstrap CI test run (#2880)
- :heavy_check_mark: K8S v1.25.13 dockerfile (#2880)
- :heavy_check_mark: K8S v1.25.13 other (#2880)
- :heavy_check_mark: K8S v1.25.13 quarkus (#2880)
- :heavy_check_mark: K8S v1.25.13 quarkus-native (#2880)
- :heavy_check_mark: K8S v1.25.13 springboot (#2880)
- :heavy_check_mark: K8S v1.25.13 webapp (#2880)
- :heavy_check_mark: K8S v1.28.1 dockerfile (#2880)
- :heavy_check_mark: K8S v1.28.1 other (#2880)
- :heavy_check_mark: K8S v1.28.1 quarkus (#2880)
- :heavy_check_mark: K8S v1.28.1 quarkus-native (#2880)
- :heavy_check_mark: K8S v1.28.1 springboot (#2880)
- :heavy_check_mark: K8S v1.28.1 webapp (#2880)
- :heavy_check_mark: OpenShift v3.10.0 other (#2880)
- :heavy_check_mark: OpenShift v3.10.0 quarkus (#2880)
- :heavy_check_mark: OpenShift v3.10.0 springboot (#2880)
- :heavy_check_mark: OpenShift v3.10.0 webapp (#2880)
- :heavy_check_mark: Windows (#2880)
- :heavy_check_mark: Finish CI test run
Test results
:heavy_check_mark: Test reports (Minikube v1.25.13-dockerfile)
[✓] DockerFileITCase - k8sBuild - k8s:build, should create image inferring contextDir from provided dockerFile configuration [✓] ContextDirITCase - k8sBuild - k8s:build, should create image with docker file and files read from provided contextDir configuration [✓] ContextDirAndDockerFileITCase - k8sBuild - k8s:build, should create image for configured special dockerFile with files added from provided contextDir [✓] ContextDirAndCustomAssemblyITCase - k8sBuild - k8s:build, should create image with docker file and files read from provided contextDir configuration (within Dockerfile, files are read from configured Assembly properties) [✓] SimpleK8sITCase - k8sBuild - k8s:build, should create image [✓] SimpleK8sITCase - k8sResource - k8s:resource, should create manifests [✓] SimpleK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] SimpleK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (1) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.28.1-dockerfile)
[✓] DockerFileITCase - k8sBuild - k8s:build, should create image inferring contextDir from provided dockerFile configuration [✓] ContextDirITCase - k8sBuild - k8s:build, should create image with docker file and files read from provided contextDir configuration [✓] ContextDirAndDockerFileITCase - k8sBuild - k8s:build, should create image for configured special dockerFile with files added from provided contextDir [✓] ContextDirAndCustomAssemblyITCase - k8sBuild - k8s:build, should create image with docker file and files read from provided contextDir configuration (within Dockerfile, files are read from configured Assembly properties) [✓] SimpleK8sITCase - k8sBuild - k8s:build, should create image [✓] SimpleK8sITCase - k8sResource - k8s:resource, should create manifests [✓] SimpleK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] SimpleK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (1) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.28.1-quarkus)
[✓] QuarkusK8sITCase - k8sBuild - k8s:build, should create image [✓] QuarkusK8sITCase - k8sResource - k8s:resource, should create manifests [✓] QuarkusK8sITCase - k8sHelm - k8s:helm, should create Helm charts [✓] QuarkusK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] QuarkusK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.25.13-quarkus)
[✓] QuarkusK8sITCase - k8sBuild - k8s:build, should create image [✓] QuarkusK8sITCase - k8sResource - k8s:resource, should create manifests [✓] QuarkusK8sITCase - k8sHelm - k8s:helm, should create Helm charts [✓] QuarkusK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] QuarkusK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.28.1-quarkus-native)
[✓] QuarkusNativeK8sITCase - k8sBuild - k8s:build, should create image [✓] QuarkusNativeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] QuarkusNativeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] QuarkusNativeK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (4) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.25.13-quarkus-native)
[✓] QuarkusNativeK8sITCase - k8sBuild - k8s:build, should create image [✓] QuarkusNativeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] QuarkusNativeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] QuarkusNativeK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (4) passed successfully!!!:heavy_check_mark: Test reports (Windows)
[✓] WindowsITCase - k8sBuild - k8s:build, should create image [✓] WindowsITCase - k8sPush - k8s:push, should push image to remote registry [✓] WindowsITCase - k8sResource - k8s:resource, should create manifests [✓] WindowsITCase - ocResource - oc:resource, should create manifests [✓] WindowsITCase - k8sHelm - k8s:helm, should create Helm charts [✓] WindowsITCase - ocHelm - oc:helm, should create Helm charts [✓] All tests (6) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.25.13-webapp)
[✓] JettyK8sITCase - k8sBuild - k8s:build, should create image [✓] TomcatJavaeeK8sITCase - k8sBuild - k8s:build should display the Tomcat webapps dir hint by default [✓] ZeroConfigK8sITCase - k8sBuild - k8s:build, should create image [✓] TomcatJakartaeeWithWebappsDirK8sITCase - k8sBuild - k8s:build, with jkube.generator.webapp.env should not display the Tomcat webapps dir hint [✓] TomcatJakartaeeK8sITCase - k8sBuild - k8s:build should display the Tomcat webapps dir hint by default [✓] TomcatJavaeeWithWebappsDirK8sITCase - k8sBuild - k8s:build, with jkube.generator.webapp.env should not display the Tomcat webapps dir hint [✓] WildFlyK8sITCase - k8sBuild - k8s:build, should create image [✓] ZeroConfigK8sITCase - k8sResource - k8s:resource, should create manifests [✓] TomcatJavaeeWithWebappsDirK8sITCase - k8sResource - k8s:resource, should create manifests [✓] JettyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] TomcatJavaeeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] TomcatJakartaeeWithWebappsDirK8sITCase - k8sResource - k8s:resource, should create manifests [✓] TomcatJakartaeeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] WildFlyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] JettyK8sWatchCopyITCase - k8sWatchCopy - k8s:watch, with mode=copy, SHOULD hot deploy the application [✓] JettyK8sWatchNoneITCase - k8sWatchNone - k8s:watch, with mode=none, SHOULD NOT hot deploy the application [✓] JettyK8sWatchBothITCase - k8sWatchBuildAndRun - k8s:watch, with mode=both, SHOULD hot deploy the application [✓] ZeroConfigK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ZeroConfigK8sITCase - k8sLog - k8s:log, should retrieve log [✓] TomcatJavaeeWithWebappsDirK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] TomcatJavaeeWithWebappsDirK8sITCase - k8sLogWithoutJavaeeMigrationNotice - k8s:log, should retrieve log without JavaEE migration notice [✓] TomcatJavaeeWithWebappsDirK8sITCase - testJavaEENodePortResponseError - JavaEE Service as NodePort response should return 500 and java.lang.NoClassDefFoundError message [✓] ZeroConfigK8sITCase - testNodePortResponse - Service as NodePort response should return String [✓] TomcatJavaeeWithWebappsDirK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] JettyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] JettyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] TomcatJavaeeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] JettyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] TomcatJakartaeeWithWebappsDirK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] TomcatJakartaeeWithWebappsDirK8sITCase - testJakartaEENodePortResponse - JakartaEE Service as NodePort response should return String [✓] TomcatJakartaeeWithWebappsDirK8sITCase - k8sLogWithoutJavaeeMigrationNotice - k8s:log, should retrieve log without JavaEE migration notice [✓] TomcatJakartaeeWithWebappsDirK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] TomcatJakartaeeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] WildFlyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] WildFlyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] TomcatJavaeeK8sITCase - k8sLog - k8s:log, should retrieve log with migration notice [✓] TomcatJavaeeK8sITCase - testJavaeeNodePortResponse - The JavaEE servlet, exposed as a NodePort Service, should return a string and contain `Hello World` [✓] WildFlyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] TomcatJavaeeK8sITCase - k8sUndeployJavaEE - k8s:undeploy, should delete all applied resources [✓] TomcatJakartaeeK8sITCase - k8sLog - k8s:log, should retrieve log with migration notice [✓] TomcatJakartaeeK8sITCase - testJakartaeeNodePortResponse - The JakartaEE servlet, exposed as a NodePort Service, should return a string and contain `Hello World` [✓] TomcatJakartaeeK8sITCase - k8sUndeployJakartaEE - k8s:undeploy, should delete all applied resources [✓] All tests (6) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.28.1-webapp)
[✓] JettyK8sITCase - k8sBuild - k8s:build, should create image [✓] ZeroConfigK8sITCase - k8sBuild - k8s:build, should create image [✓] TomcatJakartaeeWithWebappsDirK8sITCase - k8sBuild - k8s:build, with jkube.generator.webapp.env should not display the Tomcat webapps dir hint [✓] TomcatJavaeeK8sITCase - k8sBuild - k8s:build should display the Tomcat webapps dir hint by default [✓] TomcatJakartaeeK8sITCase - k8sBuild - k8s:build should display the Tomcat webapps dir hint by default [✓] TomcatJavaeeWithWebappsDirK8sITCase - k8sBuild - k8s:build, with jkube.generator.webapp.env should not display the Tomcat webapps dir hint [✓] WildFlyK8sITCase - k8sBuild - k8s:build, should create image [✓] JettyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] ZeroConfigK8sITCase - k8sResource - k8s:resource, should create manifests [✓] TomcatJavaeeWithWebappsDirK8sITCase - k8sResource - k8s:resource, should create manifests [✓] TomcatJakartaeeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] TomcatJakartaeeWithWebappsDirK8sITCase - k8sResource - k8s:resource, should create manifests [✓] TomcatJavaeeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] WildFlyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] JettyK8sWatchNoneITCase - k8sWatchNone - k8s:watch, with mode=none, SHOULD NOT hot deploy the application [✓] JettyK8sWatchCopyITCase - k8sWatchCopy - k8s:watch, with mode=copy, SHOULD hot deploy the application [✓] JettyK8sWatchBothITCase - k8sWatchBuildAndRun - k8s:watch, with mode=both, SHOULD hot deploy the application [✓] JettyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] JettyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] JettyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sITCase - testNodePortResponse - Service as NodePort response should return String [✓] TomcatJavaeeWithWebappsDirK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ZeroConfigK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] TomcatJakartaeeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] TomcatJakartaeeWithWebappsDirK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] TomcatJakartaeeWithWebappsDirK8sITCase - testJakartaEENodePortResponse - JakartaEE Service as NodePort response should return String [✓] TomcatJavaeeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] TomcatJavaeeK8sITCase - k8sLog - k8s:log, should retrieve log with migration notice [✓] TomcatJavaeeK8sITCase - testJavaeeNodePortResponse - The JavaEE servlet, exposed as a NodePort Service, should return a string and contain `Hello World` [✓] TomcatJavaeeK8sITCase - k8sUndeployJavaEE - k8s:undeploy, should delete all applied resources [✓] WildFlyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] WildFlyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] TomcatJavaeeWithWebappsDirK8sITCase - k8sLogWithoutJavaeeMigrationNotice - k8s:log, should retrieve log without JavaEE migration notice [✓] TomcatJavaeeWithWebappsDirK8sITCase - testJavaEENodePortResponseError - JavaEE Service as NodePort response should return 500 and java.lang.NoClassDefFoundError message [✓] WildFlyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] TomcatJavaeeWithWebappsDirK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] TomcatJakartaeeK8sITCase - k8sLog - k8s:log, should retrieve log with migration notice [✓] TomcatJakartaeeK8sITCase - testJakartaeeNodePortResponse - The JakartaEE servlet, exposed as a NodePort Service, should return a string and contain `Hello World` [✓] TomcatJakartaeeK8sITCase - k8sUndeployJakartaEE - k8s:undeploy, should delete all applied resources [✓] TomcatJakartaeeWithWebappsDirK8sITCase - k8sLogWithoutJavaeeMigrationNotice - k8s:log, should retrieve log without JavaEE migration notice [✓] TomcatJakartaeeWithWebappsDirK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (6) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.25.13-springboot)
[✓] HelmConfigK8sITCase - k8sResource - k8s:resource, no specified profile, should create default resource manifests [✓] CompleteDockerITCase - k8sBuild - k8s:build, should create image and assembly files [✓] ZeroConfigFatJarK8sITCase - k8sBuild - k8s:build, should create fat jar image [✓] CustomResourceK8sITCase - k8sBuild - k8s:build, should create image [✓] ZeroConfigK8sITCase - k8sBuild - k8s:build, should create layered jar image [✓] CompleteK8sITCase - k8sBuild - k8s:build, should create image [✓] CompleteK8sJibITCase - k8sBuild - k8s:build, should create JIB image [✓] HelmConfigK8sITCase - k8sHelm - k8s:helm, should create Helm charts [✓] CompleteDockerITCase - k8sResource - k8s:resource, should create manifests in specific directory [✓] ZeroConfigFatJarK8sITCase - k8sResource - k8s:resource, should create manifests [✓] HelmConfigK8sITCase - k8sHelmPush - k8s:helm-push, should push the charts [✓] CustomResourceK8sITCase - k8sPush - k8s:push, should push image to remote registry [✓] ZeroConfigK8sITCase - k8sPush - k8s:push, should push image to remote registry [✓] CompleteK8sJibITCase - k8sResource - k8s:resource, should create manifests [✓] CompleteDockerITCase - k8sApply - k8s:apply, should deploy pod and service form manifests in specific directory [✓] HelmConfigK8sITCase - k8sHelmInstall - k8s:helm-install, should install the charts [✓] CompleteK8sITCase - k8sResource - k8s:resource, should create manifests [✓] CompleteK8sJibITCase - k8sPush - k8s:push, should push image to remote registry [✓] ZeroConfigK8sITCase - k8sResource - k8s:resource, should create manifests [✓] CompleteDockerITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] CustomResourceK8sITCase - k8sResource - k8s:resource, should create manifests [✓] HelmConfigK8sITCase - k8sHelmUninstall - k8s:helm-uninstall, should uninstall the charts [✓] ZeroConfigFatJarK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ZeroConfigK8sITCase - k8sHelm - k8s:helm, should create Helm charts [✓] HelmConfigK8sITCase - k8sHelmUninstall_whenNoReleasePresent_thenErrorMessageDisplayed - k8s:helm-uninstall, no release present, display error message [✓] ZeroConfigFatJarK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sGradleITCase - k8sBuild - k8sBuild, should create image [✓] CompleteK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ZeroConfigFatJarK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sGradleITCase - k8sResource - k8sResource, should create manifests [✓] ZeroConfigK8sGradleITCase - k8sHelm - k8sHelm, should create Helm charts [✓] CompleteK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] CompleteK8sJibITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CompleteK8sJibITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sGradleITCase - k8sPush - k8sPush, should push image to remote registry [✓] CustomResourceK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CustomResourceK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CustomResourceK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sGradleITCase - k8sApply - k8sApply, should deploy pod and service [✓] ZeroConfigK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sGradleITCase - k8sLog - k8sLog, should retrieve log [✓] ZeroConfigK8sGradleITCase - k8sUndeploy - k8sUndeploy, should delete all applied resources [✓] ZeroConfigK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (6) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.28.1-springboot)
[✓] CompleteDockerITCase - k8sBuild - k8s:build, should create image and assembly files [✓] HelmConfigK8sITCase - k8sResource - k8s:resource, no specified profile, should create default resource manifests [✓] ZeroConfigFatJarK8sITCase - k8sBuild - k8s:build, should create fat jar image [✓] CustomResourceK8sITCase - k8sBuild - k8s:build, should create image [✓] ZeroConfigK8sITCase - k8sBuild - k8s:build, should create layered jar image [✓] CompleteK8sITCase - k8sBuild - k8s:build, should create image [✓] CompleteK8sJibITCase - k8sBuild - k8s:build, should create JIB image [✓] HelmConfigK8sITCase - k8sHelm - k8s:helm, should create Helm charts [✓] CompleteDockerITCase - k8sResource - k8s:resource, should create manifests in specific directory [✓] ZeroConfigFatJarK8sITCase - k8sResource - k8s:resource, should create manifests [✓] HelmConfigK8sITCase - k8sHelmPush - k8s:helm-push, should push the charts [✓] CompleteK8sJibITCase - k8sResource - k8s:resource, should create manifests [✓] CustomResourceK8sITCase - k8sPush - k8s:push, should push image to remote registry [✓] ZeroConfigK8sITCase - k8sPush - k8s:push, should push image to remote registry [✓] CompleteDockerITCase - k8sApply - k8s:apply, should deploy pod and service form manifests in specific directory [✓] CompleteK8sITCase - k8sResource - k8s:resource, should create manifests [✓] HelmConfigK8sITCase - k8sHelmInstall - k8s:helm-install, should install the charts [✓] CompleteK8sJibITCase - k8sPush - k8s:push, should push image to remote registry [✓] ZeroConfigK8sITCase - k8sResource - k8s:resource, should create manifests [✓] CompleteDockerITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] CustomResourceK8sITCase - k8sResource - k8s:resource, should create manifests [✓] HelmConfigK8sITCase - k8sHelmUninstall - k8s:helm-uninstall, should uninstall the charts [✓] ZeroConfigFatJarK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ZeroConfigK8sITCase - k8sHelm - k8s:helm, should create Helm charts [✓] HelmConfigK8sITCase - k8sHelmUninstall_whenNoReleasePresent_thenErrorMessageDisplayed - k8s:helm-uninstall, no release present, display error message [✓] ZeroConfigFatJarK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sGradleITCase - k8sBuild - k8sBuild, should create image [✓] CompleteK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ZeroConfigK8sGradleITCase - k8sResource - k8sResource, should create manifests [✓] ZeroConfigFatJarK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sGradleITCase - k8sHelm - k8sHelm, should create Helm charts [✓] CompleteK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] CompleteK8sJibITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CompleteK8sJibITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sGradleITCase - k8sPush - k8sPush, should push image to remote registry [✓] CustomResourceK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CustomResourceK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CustomResourceK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sGradleITCase - k8sApply - k8sApply, should deploy pod and service [✓] ZeroConfigK8sGradleITCase - k8sLog - k8sLog, should retrieve log [✓] ZeroConfigK8sGradleITCase - k8sUndeploy - k8sUndeploy, should delete all applied resources [✓] ZeroConfigK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (6) passed successfully!!!:x: Test reports (OpenShift v3.10.0-quarkus)
[✓] QuarkusOcITCase - ocBuild - oc:build, should create image [✓] QuarkusOcITCase - ocResource - oc:resource, should create manifests [✓] QuarkusOcITCase - ocHelm - oc:helm, should create Helm charts [✓] QuarkusOcTraceEnabledITCase - ocBuild - oc:build, with org.slf4j.simpleLogger.defaultLogLevel=trace, should create image and print trace logs [✓] QuarkusOcTraceEnabledITCase - ocResource - oc:resource, should create manifests [✓] QuarkusOcITCase - ocApply - oc:apply, should deploy pod and service [✓] QuarkusOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [X] QuarkusOcTraceEnabledITCase - ocApply - oc:apply, with org.slf4j.simpleLogger.defaultLogLevel=trace, should deploy pod and service and print trace logs [✓] QuarkusOcTraceEnabledITCase - ocLog - oc:log, with org.slf4j.simpleLogger.defaultLogLevel=trace, should retrieve log and print trace logs [✓] QuarkusOcTraceEnabledITCase - ocUndeploy - oc:undeploy, with org.slf4j.simpleLogger.defaultLogLevel=trace, should delete all applied resources and print trace logs [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.25.13-other)
[✓] VertxK8sITCase - k8sBuild - k8s:build, should create image [✓] ThorntailK8sITCase - k8sBuild - k8s:build, should create image [✓] KarafK8sITCase - k8sBuild - k8s:build, should create image [✓] WildflyJarK8sITCase - k8sBuild - k8s:build, should create image [✓] OpenLibertyK8sITCase - k8sBuild - k8s:build, should create image [✓] VertxK8sITCase - k8sResource - k8s:resource, should create manifests [✓] ThorntailK8sITCase - k8sResource - k8s:resource, should create manifests [✓] KarafK8sITCase - k8sResource - k8s:resource, should create manifest for Kubernetes [✓] BuildPacksBuildStrategyK8sITCase - k8sBuild - k8s:build, should create container image using buildpacks [✓] OpenLibertyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] WildflyJarK8sITCase - k8sResource - k8s:resource, should create manifests [✓] VertxK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] BuildPacksBuildStrategyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] DslK8sGradleITCase - k8sBuild - k8sBuild, should create image [✓] VertxK8sITCase - k8sLog - k8s:log, should retrieve log [✓] DslK8sGradleITCase - k8sResource - k8sResource, should create manifests [✓] DslK8sGradleITCase - k8sHelm - k8sHelm, should create Helm charts [✓] VertxK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ThorntailK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ThorntailK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] KarafK8sITCase - K8sApply - k8s:apply, should apply manifests on k8s cluster [✓] KarafK8sITCase - k8sLog - k8s:log [✓] KarafK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] OpenLibertyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] OpenLibertyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] OpenLibertyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] WildflyJarK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] WildflyJarK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] BuildPacksBuildStrategyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] DslK8sGradleITCase - k8sApply - k8sApply, should deploy pod and service [✓] DslK8sGradleITCase - k8sLog - k8sLog, should retrieve log [✓] DslK8sGradleITCase - k8sUndeploy - k8sUndeploy, should delete all applied resources [✓] BuildPacksBuildStrategyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (4) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.28.1-other)
[✓] VertxK8sITCase - k8sBuild - k8s:build, should create image [✓] ThorntailK8sITCase - k8sBuild - k8s:build, should create image [✓] KarafK8sITCase - k8sBuild - k8s:build, should create image [✓] WildflyJarK8sITCase - k8sBuild - k8s:build, should create image [✓] OpenLibertyK8sITCase - k8sBuild - k8s:build, should create image [✓] VertxK8sITCase - k8sResource - k8s:resource, should create manifests [✓] ThorntailK8sITCase - k8sResource - k8s:resource, should create manifests [✓] KarafK8sITCase - k8sResource - k8s:resource, should create manifest for Kubernetes [✓] BuildPacksBuildStrategyK8sITCase - k8sBuild - k8s:build, should create container image using buildpacks [✓] OpenLibertyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] WildflyJarK8sITCase - k8sResource - k8s:resource, should create manifests [✓] VertxK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] BuildPacksBuildStrategyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] VertxK8sITCase - k8sLog - k8s:log, should retrieve log [✓] DslK8sGradleITCase - k8sBuild - k8sBuild, should create image [✓] VertxK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] DslK8sGradleITCase - k8sResource - k8sResource, should create manifests [✓] DslK8sGradleITCase - k8sHelm - k8sHelm, should create Helm charts [✓] ThorntailK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ThorntailK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] KarafK8sITCase - K8sApply - k8s:apply, should apply manifests on k8s cluster [✓] KarafK8sITCase - k8sLog - k8s:log [✓] KarafK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] OpenLibertyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] OpenLibertyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] OpenLibertyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] WildflyJarK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] WildflyJarK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] BuildPacksBuildStrategyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] DslK8sGradleITCase - k8sApply - k8sApply, should deploy pod and service [✓] DslK8sGradleITCase - k8sLog - k8sLog, should retrieve log [✓] DslK8sGradleITCase - k8sUndeploy - k8sUndeploy, should delete all applied resources [✓] BuildPacksBuildStrategyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (6) passed successfully!!!:heavy_check_mark: Test reports (OpenShift v3.10.0-springboot)
[✓] HelmConfigOcITCase - ocResource - oc:resource, no specified profile, should create default resource manifests [✓] HelmConfigOcITCase - ocHelm - oc:helm, should create Helm charts [✓] HelmConfigOcITCase - ocHelmPush - oc:helm-push, should push the charts [✓] HelmConfigOcITCase - ocHelmInstall - oc:helm-install, should install the charts [✓] HelmConfigOcITCase - ocHelmUninstall - oc:helm-uninstall, should uninstall the charts [✓] HelmConfigOcITCase - ocHelmUninstall_whenNoReleasePresent_thenErrorMessageDisplayed - oc:helm-uninstall, no release present, display error message [✓] ZeroConfigOcGradleITCase - ocBuild - ocBuild, should create image [✓] ZeroConfigOcGradleITCase - ocResource - ocResource, should create manifests [✓] ZeroConfigOcITCase - ocBuild - oc:build, should create image [✓] ZeroConfigOcITCase - ocResource - oc:resource, should create manifests [✓] CompleteOcDockerITCase - ocBuild - oc:build, with jkube.build.strategy=docker, should create image [✓] CompleteOcDockerITCase - ocResource - oc:resource, should create manifests [✓] WatchOcITCase - watch_whenSourceModified_shouldLiveReloadChanges - watch, SHOULD hot reload application on changes [✓] LayeredJarDisabledOcDockerITCase - ocBuild - oc:build, with jkube.build.strategy=docker, should create image [✓] ZeroConfigOcGradleITCase - ocApply - ocApply, should deploy pod and service [✓] LayeredJarDisabledOcDockerITCase - ocResource - oc:resource, should create manifests [✓] ZeroConfigOcGradleITCase - ocHelm - ocHelm, should create Helm charts [✓] ZeroConfigOcGradleITCase - ocLog - ocLog, should retrieve log [✓] ZeroConfigOcGradleITCase - ocUndeploy - ocUndeploy, should delete all applied resources [✓] ZeroConfigOcITCase - ocApply - oc:apply, should deploy pod and service [✓] ZeroConfigOcITCase - ocHelm - oc:helm, should create Helm charts [✓] CompleteOcDockerITCase - ocApply - oc:apply, should deploy pod and service [✓] ZeroConfigOcITCase - ocLog - oc:log, should retrieve log [✓] CompleteOcDockerITCase - ocLog - oc:log, should retrieve log [✓] ZeroConfigOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] LayeredJarDisabledOcDockerITCase - ocApply - oc:apply, should deploy pod and service [✓] CompleteOcDockerITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] LayeredJarDisabledOcDockerITCase - ocLog - oc:log, should retrieve log [✓] LayeredJarDisabledOcDockerITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (OpenShift v3.10.0-webapp)
[✓] WildFlyOcDockerModeITCase - ocBuild - oc:build, should create image using docker [✓] WildFlyOcDockerModeITCase - ocResource - k8s:resource, should create manifests [✓] ZeroConfigOcITCase - ocBuild - oc:build, should create image [✓] ZeroConfigOcITCase - ocResource - oc:resource, should create manifests [✓] JettyOcITCase - ocBuild - oc:build, should create image [✓] JettyOcITCase - ocResource - oc:resource, should create manifests [✓] WildFlyOcITCase - ocBuild - oc:build, should create image [✓] WildFlyOcITCase - ocResource - oc:resource, should create manifests [✓] WildFlyOcDockerModeITCase - ocApply - oc:apply, should deploy pod and service [✓] WildFlyOcDockerModeITCase - ocLog - oc:log, should retrieve logs [✓] ZeroConfigOcITCase - ocApply - oc:apply, should deploy pod and service [✓] ZeroConfigOcITCase - testNodePortResponse - Service as NodePort response should return String [✓] WildFlyOcDockerModeITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] ZeroConfigOcITCase - ocLog - oc:log, should retrieve log [✓] JettyOcITCase - ocApply - oc:apply, should deploy pod and service [✓] ZeroConfigOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] JettyOcITCase - ocLog - oc:log, should retrieve log [✓] JettyOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] WildFlyOcITCase - ocApply - oc:apply, should deploy pod and service [✓] WildFlyOcITCase - ocLog - oc:log, should retrieve logs [✓] WildFlyOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (OpenShift v3.10.0-other)
[✓] DslOcGradleITCase - ocBuild - ocBuild, should create image [✓] DslOcGradleITCase - ocResource - ocResource, should create manifests [✓] ThorntailOcITCase - ocBuild - oc:build, should create image [✓] ThorntailOcITCase - ocResource - oc:resource, should create manifests [✓] WildflyJarOcITCase - ocBuild - oc:build, should create image [✓] WildflyJarOcITCase - ocResource - oc:resource, should create manifests [✓] OpenLibertyOcITCase - ocBuild - oc:build, should create image [✓] OpenLibertyOcITCase - ocResource - oc:resource, should create manifests [✓] VertxOcITCase - ocBuild - oc:build, should create image [✓] VertxOcITCase - ocResource - oc:resource, should create manifests [✓] KarafOcITCase - ocBuild - oc:build, should create image [✓] KarafOcITCase - ocResource - oc:resource, should create resource manifests [✓] DslOcGradleITCase - ocApply - ocApply, should deploy pod and service [✓] DslOcGradleITCase - ocHelm - ocHelm, should create Helm charts [✓] DslOcGradleITCase - ocLog - ocLog, should retrieve log [✓] DslOcGradleITCase - ocUndeploy - ocUndeploy, should delete all applied resources [✓] ThorntailOcITCase - ocApply - oc:apply, should deploy pod and service [✓] ThorntailOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] WildflyJarOcITCase - ocApply - oc:apply, should deploy pod and service [✓] WildflyJarOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] OpenLibertyOcITCase - ocApply - oc:apply, should deploy pod and service [✓] OpenLibertyOcITCase - ocLog - oc:log, should retrieve log [✓] VertxOcITCase - ocApply - oc:apply, should deploy pod and service [✓] OpenLibertyOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] VertxOcITCase - k8sLog - oc:log, should retrieve log [✓] VertxOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] KarafOcITCase - ocApply - oc:apply, should create pod, service and route [✓] KarafOcITCase - ocLog - oc:log, should retrieve log [✓] KarafOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (OpenShift v3.10.0-quarkus)
[✓] QuarkusOcTraceEnabledITCase - ocBuild - oc:build, with org.slf4j.simpleLogger.defaultLogLevel=trace, should create image and print trace logs [✓] QuarkusOcTraceEnabledITCase - ocResource - oc:resource, should create manifests [✓] QuarkusOcITCase - ocBuild - oc:build, should create image [✓] QuarkusOcITCase - ocResource - oc:resource, should create manifests [✓] QuarkusOcTraceEnabledITCase - ocApply - oc:apply, with org.slf4j.simpleLogger.defaultLogLevel=trace, should deploy pod and service and print trace logs [✓] QuarkusOcITCase - ocHelm - oc:helm, should create Helm charts [✓] QuarkusOcTraceEnabledITCase - ocLog - oc:log, with org.slf4j.simpleLogger.defaultLogLevel=trace, should retrieve log and print trace logs [✓] QuarkusOcITCase - ocApply - oc:apply, should deploy pod and service [✓] QuarkusOcTraceEnabledITCase - ocUndeploy - oc:undeploy, with org.slf4j.simpleLogger.defaultLogLevel=trace, should delete all applied resources and print trace logs [✓] QuarkusOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.62%. Comparing base (
1ac4f7c) to head (4f19318). Report is 319 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2880 +/- ##
=============================================
+ Coverage 59.36% 70.62% +11.26%
- Complexity 4586 5012 +426
=============================================
Files 500 486 -14
Lines 21211 19453 -1758
Branches 2830 2505 -325
=============================================
+ Hits 12591 13739 +1148
+ Misses 7370 4491 -2879
+ Partials 1250 1223 -27
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarCloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@arsenalzp : We discussed this internally and decided that we do not want to add this much complication to tackling this issue. I think the simplest approach would be to log a message (see https://github.com/eclipse-jkube/jkube/issues/2832#issuecomment-2048932681)
Would it be possible for you to update it to make this a bit simpler?
@arsenalzp : We discussed this internally and decided that we do not want to add this much complication to tackling this issue. I think the simplest approach would be to log a message (see #2832 (comment))
Would it be possible for you to update it to make this a bit simpler?
Hello, Yes, it is OK for me!
Fixed. Additional logic was removed, keep it as it was initially, INFO messages were added. Could you please be so kind to check it?
Quality Gate passed
Issues
1 New issue
0 Accepted issues
Measures
0 Security Hotspots
85.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarCloud
@arsenalzp : Is it possible to just have log statements without relying on propertiesFile field?
@arsenalzp : Is it possible to just have log statements without relying on
propertiesFilefield?
Technically it is possible to show the message somewhere in SpringBootUtil.java or SpringBootConfiguration classes, however I decided to show Generator-related message in the Generator class. So, it is necessary to bring properties file info into generator class, it was done by extending Properties class which is used in JavaProject class.
Does it make sense?
@arsenalzp : Hello, I took a look at your changes again. However, it's a bit of a complex change for just logging the used properties file.
I think you can extract the property file getting used from this method here (maybe create a separate method that receives JavaProject, KitLogger) and log the relative path of the properties file getting used by the plugin.
https://github.com/eclipse-jkube/jkube/blob/e1cde0bd0d4ab1a659db7b1f7a884705048b27de/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/SpringBootUtil.java#L67-L70
Could you please check if this approach would work out?
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
97.9% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarCloud
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
98.2% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarCloud