jkube
jkube copied to clipboard
PortForwardServiceTest.setUp The declared Exception exception is never thrown
Description
The method PortForwardServiceTest.setUp declares an Exception that is never thrown.
The following line https://github.com/eclipse-jkube/jkube/blob/108f6ed341bbc4760b7e6b8497ea28004945fc58/jkube-kit/config/service/src/test/java/org/eclipse/jkube/kit/config/service/PortForwardServiceTest.java#L54
- [ ] should be changed to:
void setUp() {
Before you start :red_circle:
:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down::point_down::point_down::point_down::point_down::point_down::point_down: Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.
How to manually test my changes
Kubernetes
If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.
- Minikube get started guide
- Kind (Requires Docker) quick start
OpenShift
If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.
Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ?
icon and from the context menu select Command line tools
, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)
Hi, I can also help with this issue
@clarenced Hello, first-timers-only issue labels are created for people who are contributing for the first time. I think you should look into good-first-issue
/help-wanted
labels.
Hi, You can assign this to me. I haven't done any contribution before.
Hey team! @manusa mind if I take this one as my first contribution? Sorry I jumped the gun a little and I already got a PR open 🥲 https://github.com/eclipse-jkube/jkube/pull/3331