jkube
jkube copied to clipboard
AssemblyFileSetUtilsExcludesTest.setUp The declared Exception exception is never thrown
Description
The method AssemblyFileSetUtilsExcludesTest.setUp declares an Exception that is never thrown.
The following line https://github.com/eclipse-jkube/jkube/blob/5da6068d7756784aef9569568ee80f98da97e296/jkube-kit/common/src/test/java/org/eclipse/jkube/kit/common/archive/AssemblyFileSetUtilsExcludesTest.java#L33
- [ ] should be changed to:
public void setUp() {
Before you start :red_circle:
:point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down: :point_down::point_down::point_down::point_down::point_down::point_down::point_down: Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.
How to manually test my changes
Kubernetes
If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.
- Minikube get started guide
- Kind (Requires Docker) quick start
OpenShift
If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.
Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ?
icon and from the context menu select Command line tools
, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)
Can I work on this? Could you please assign this to me.
@ShantKhatri : I'm not 100% sure about I think you've contributed previously to the project. Am I right? first-timers-only
tagged issues are created for people who are contributing to the project for the first time.
@ShantKhatri : I think you were working on https://github.com/eclipse/jkube/issues/2316 . You analyzed tests that might require refactoring to reduce dependency on mockito.
I think we can create sub-tasks from that spread sheet as isolated issues. I've created #2597 #2598 . Would you be interested in working on it?
@ShantKhatri : I think you were working on #2316 . You analyzed tests that might require refactoring to reduce dependency on mockito.
I think we can create sub-tasks from that spread sheet as isolated issues. I've created #2597 #2598 . Would you be interested in working on it?
Sure, I'll work on these issues.
Hii i am new to open source and want to contribute to this project and i have good knowledge of java and Android in java . but i dont know to run the project locally i have try so many thing but it fails . so can anyone please help me in set-up and run it locally
Error when running command
$ mvn clean install
You won't be able to run some tests on Windows.
To build the project you'll need to provide the -DskipTests
maven flag.
For this particular issue, we can rely on the build automation platform to ensure that you didn't break anything.
Shall I assign this to you @Harshitchopde ?
You won't be able to run some tests on Windows. To build the project you'll need to provide the
-DskipTests
maven flag. For this particular issue, we can rely on the build automation platform to ensure that you didn't break anything. Shall I assign this to you @Harshitchopde ?
sure