jkube
jkube copied to clipboard
Published
20 hours ago •
eclipse-jkube
eclipse-jkube
Fixed #1769 Suggest to rename the image name
…sh task fails
Description
Fixes #1769
Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change
- [ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)
Checklist
- [x] I have read the contributing guidelines
- [x] I signed-off my commit with a user that has signed the Eclipse Contributor Agreement
- [x] My code follows the style guidelines of this project
- [x] I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
- [ ] I use conventional commits in my commit messages
- [x] I have performed a self-review of my code
- [ ] I Added CHANGELOG entry
- [ ] I have updated the documentation accordingly
- [x] No new bugs, code smells, etc. in SonarCloud report
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] I tested my code in Kubernetes
- [ ] I tested my code in OpenShift
Eclipse JKube CI Report
Started new GH workflow run for https://github.com/eclipse/jkube/pull/2245 (2023-09-01T08:20:32Z)
:gear: JKube E2E Tests (6046868103)
- :heavy_check_mark: Bootstrap CI test run (#2245)
- :heavy_check_mark: K8S v1.22.17 dockerfile (#2245)
- :heavy_check_mark: K8S v1.22.17 other (#2245)
- :heavy_check_mark: K8S v1.22.17 quarkus (#2245)
- :heavy_check_mark: K8S v1.22.17 quarkus-native (#2245)
- :x: K8S v1.22.17 springboot (#2245)
- :heavy_check_mark: K8S v1.22.17 webapp (#2245)
- :heavy_check_mark: K8S v1.25.4 dockerfile (#2245)
- :heavy_check_mark: K8S v1.25.4 other (#2245)
- :heavy_check_mark: K8S v1.25.4 quarkus (#2245)
- :heavy_check_mark: K8S v1.25.4 quarkus-native (#2245)
- :x: K8S v1.25.4 springboot (#2245)
- :heavy_check_mark: K8S v1.25.4 webapp (#2245)
- :heavy_check_mark: OpenShift v3.11.0 other (#2245)
- :heavy_check_mark: OpenShift v3.11.0 quarkus (#2245)
- :x: OpenShift v3.11.0 springboot (#2245)
- :heavy_check_mark: OpenShift v3.11.0 webapp (#2245)
- :heavy_check_mark: Windows (#2245)
- :heavy_check_mark: Finish CI test run
Test results
:heavy_check_mark: Test reports (Minikube v1.22.17-dockerfile)
[✓] DockerFileITCase - k8sBuild - k8s:build, should create image inferring contextDir from provided dockerFile configuration [✓] ContextDirAndDockerFileITCase - k8sBuild - k8s:build, should create image for configured special dockerFile with files added from provided contextDir [✓] ContextDirITCase - k8sBuild - k8s:build, should create image with docker file and files read from provided contextDir configuration [✓] ContextDirAndCustomAssemblyITCase - k8sBuild - k8s:build, should create image with docker file and files read from provided contextDir configuration (within Dockerfile, files are read from configured Assembly properties) [✓] SimpleK8sITCase - k8sBuild - k8s:build, should create image [✓] SimpleK8sITCase - k8sResource - k8s:resource, should create manifests [✓] SimpleK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] SimpleK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (1) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.22.17-other)
[✓] KarafK8sITCase - k8sBuild - k8s:build, should create image [✓] VertxK8sITCase - k8sBuild - k8s:build, should create image [✓] ThorntailK8sITCase - k8sBuild - k8s:build, should create image [✓] OpenLibertyK8sITCase - k8sBuild - k8s:build, should create image [✓] WildflyJarK8sITCase - k8sBuild - k8s:build, should create image [✓] VertxK8sITCase - k8sResource - k8s:resource, should create manifests [✓] KarafK8sITCase - k8sResource - k8s:resource, should create manifest for Kubernetes [✓] ThorntailK8sITCase - k8sResource - k8s:resource, should create manifests [✓] OpenLibertyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] WildflyJarK8sITCase - k8sResource - k8s:resource, should create manifests [✓] VertxK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] VertxK8sITCase - k8sLog - k8s:log, should retrieve log [✓] KarafK8sITCase - K8sApply - k8s:apply, should apply manifests on k8s cluster [✓] VertxK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] DslK8sGradleITCase - k8sBuild - k8sBuild, should create image [✓] DslK8sGradleITCase - k8sResource - k8sResource, should create manifests [✓] DslK8sGradleITCase - k8sHelm - k8sHelm, should create Helm charts [✓] KarafK8sITCase - k8sLog - k8s:log [✓] KarafK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ThorntailK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ThorntailK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] OpenLibertyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] OpenLibertyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] OpenLibertyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] WildflyJarK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] DslK8sGradleITCase - k8sApply - k8sApply, should deploy pod and service [✓] DslK8sGradleITCase - k8sLog - k8sLog, should retrieve log [✓] DslK8sGradleITCase - k8sUndeploy - k8sUndeploy, should delete all applied resources [✓] WildflyJarK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (4) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.22.17-quarkus)
[✓] QuarkusK8sITCase - k8sBuild - k8s:build, should create image [✓] QuarkusK8sITCase - k8sResource - k8s:resource, should create manifests [✓] QuarkusK8sITCase - k8sHelm - k8s:helm, should create Helm charts [✓] QuarkusK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] QuarkusK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.22.17-quarkus-native)
[✓] QuarkusNativeK8sITCase - k8sBuild - k8s:build, should create image [✓] QuarkusNativeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] QuarkusNativeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] QuarkusNativeK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (4) passed successfully!!!:x: Test reports (Minikube v1.22.17-springboot)
[✓] HelmConfigITCase - k8sResource - k8s:resource, no specified profile, should create default resource manifests [✓] CompleteDockerITCase - k8sBuild - k8s:build, should create image and assembly files [✓] CustomResourceK8sITCase - k8sBuild - k8s:build, should create image [X] CompleteK8sITCase - k8sBuild - k8s:build, should create image [X] ZeroConfigK8sITCase - k8sBuild - k8s:build, should create layered jar image [✓] ZeroConfigFatJarK8sITCase - k8sBuild - k8s:build, should create fat jar image [✓] HelmConfigITCase - k8sHelm - k8s:helm, should create Helm charts [✓] CompleteDockerITCase - k8sResource - k8s:resource, should create manifests in specific directory [✓] ZeroConfigFatJarK8sITCase - k8sResource - k8s:resource, should create manifests [X] HelmConfigITCase - k8sHelmPush - k8s:helm-push, should push the charts [✓] CompleteK8sJibITCase - k8sBuild - k8s:build, should create JIB image [✓] CustomResourceK8sITCase - k8sPush - k8s:push, should push image to remote registry [✓] ZeroConfigK8sITCase - k8sPush - k8s:push, should push image to remote registry [✓] CompleteDockerITCase - k8sApply - k8s:apply, should deploy pod and service form manifests in specific directory [✓] CompleteK8sITCase - k8sResource - k8s:resource, should create manifests [✓] CompleteK8sJibITCase - k8sResource - k8s:resource, should create manifests [✓] ZeroConfigK8sITCase - k8sResource - k8s:resource, should create manifests [✓] CompleteDockerITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] CustomResourceK8sITCase - k8sResource - k8s:resource, should create manifests [✓] ZeroConfigFatJarK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CompleteK8sJibITCase - k8sPush - k8s:push, should push image to remote registry [✓] ZeroConfigK8sITCase - k8sHelm - k8s:helm, should create Helm charts [✓] ZeroConfigFatJarK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigFatJarK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [X] ZeroConfigK8sGradleITCase - k8sBuild - k8sBuild, should create image [X] ZeroConfigK8sGradleITCase - k8sResource - k8sResource, should create manifests [X] ZeroConfigK8sGradleITCase - k8sHelm - k8sHelm, should create Helm charts [X] ZeroConfigK8sGradleITCase - k8sPush - k8sPush, should push image to remote registry [X] CompleteK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CompleteK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] CustomResourceK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CustomResourceK8sITCase - k8sLog - k8s:log, should retrieve log [✓] CustomResourceK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] CompleteK8sJibITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CompleteK8sJibITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ZeroConfigK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [X] ZeroConfigK8sGradleITCase - k8sApply - k8sApply, should deploy pod and service [X] ZeroConfigK8sGradleITCase - k8sLog - k8sLog, should retrieve log [✓] ZeroConfigK8sGradleITCase - k8sUndeploy - k8sUndeploy, should delete all applied resources [✓] All tests (6) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.22.17-webapp)
[✓] TomcatJavaeeK8sITCase - k8sBuild - k8s:build should display the Tomcat webapps dir hint by default [✓] TomcatJakartaeeK8sITCase - k8sBuild - k8s:build should display the Tomcat webapps dir hint by default [✓] ZeroConfigK8sITCase - k8sBuild - k8s:build, should create image [✓] JettyK8sITCase - k8sBuild - k8s:build, should create image [✓] WildFlyK8sITCase - k8sBuild - k8s:build, should create image [✓] TomcatJakartaeeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] TomcatJavaeeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] ZeroConfigK8sITCase - k8sResource - k8s:resource, should create manifests [✓] JettyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] WildFlyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] JettyK8sWatchITCase - k8sWatchCopy - k8s:watch, with mode=copy, SHOULD hot deploy the application [✓] JettyK8sWatchITCase - k8sWatchNone - k8s:watch, with mode=none, SHOULD NOT hot deploy the application [✓] JettyK8sWatchITCase - k8sWatchBuildAndRun - k8s:watch, with mode=both, SHOULD hot deploy the application [✓] TomcatJakartaeeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] TomcatJavaeeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] TomcatJavaeeK8sITCase - k8sLog - k8s:log, should retrieve log with migration notice [✓] TomcatJavaeeK8sITCase - testJavaeeNodePortResponse - The JavaEE servlet, exposed as a NodePort Service, should return a string and contain `Hello World` [✓] TomcatJavaeeK8sITCase - k8sUndeployJavaEE - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] TomcatJavaeeK8sITCase - k8sBuildWithWebappEnv - k8s:build, with jkube.generator.webapp.env should not display the Tomcat webapps dir hint [✓] ZeroConfigK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sITCase - testNodePortResponse - Service as NodePort response should return String [✓] JettyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ZeroConfigK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] JettyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] JettyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] WildFlyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] WildFlyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] TomcatJakartaeeK8sITCase - k8sLog - k8s:log, should retrieve log with migration notice [✓] TomcatJakartaeeK8sITCase - testJakartaeeNodePortResponse - The JakartaEE servlet, exposed as a NodePort Service, should return a string and contain `Hello World` [✓] WildFlyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] TomcatJakartaeeK8sITCase - k8sUndeployJakartaEE - k8s:undeploy, should delete all applied resources [✓] TomcatJavaeeK8sITCase - k8sApplyWithNewDeployment - k8s:apply, should deploy pod and service with new image [✓] TomcatJavaeeK8sITCase - k8sLogWithoutJavaeeMigrationNotice - k8s:log, should retrieve log without JavaEE migration notice [✓] TomcatJavaeeK8sITCase - testJavaEENodePortResponseError - JavaEE Service as NodePort response should return 500 and java.lang.NoClassDefFoundError message [✓] TomcatJakartaeeK8sITCase - k8sBuildWithWebappEnv - k8s:build, with jkube.generator.webapp.env should not display the Tomcat webapps dir hint [✓] TomcatJavaeeK8sITCase - finalK8sUndeploy - Final k8s:undeploy, should delete all applied resources [✓] TomcatJakartaeeK8sITCase - k8sApplyWithNewDeployment - k8s:apply, should deploy pod and service with new image [✓] TomcatJakartaeeK8sITCase - testJakartaEENodePortResponse - JakartaEE Service as NodePort response should return String [✓] TomcatJakartaeeK8sITCase - k8sLogWithoutJavaeeMigrationNotice - k8s:log, should retrieve log without JavaEE migration notice [✓] TomcatJakartaeeK8sITCase - finalK8sUndeploy - Final k8s:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.25.4-dockerfile)
[✓] DockerFileITCase - k8sBuild - k8s:build, should create image inferring contextDir from provided dockerFile configuration [✓] ContextDirITCase - k8sBuild - k8s:build, should create image with docker file and files read from provided contextDir configuration [✓] ContextDirAndCustomAssemblyITCase - k8sBuild - k8s:build, should create image with docker file and files read from provided contextDir configuration (within Dockerfile, files are read from configured Assembly properties) [✓] ContextDirAndDockerFileITCase - k8sBuild - k8s:build, should create image for configured special dockerFile with files added from provided contextDir [✓] SimpleK8sITCase - k8sBuild - k8s:build, should create image [✓] SimpleK8sITCase - k8sResource - k8s:resource, should create manifests [✓] SimpleK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] SimpleK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (1) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.25.4-other)
[✓] KarafK8sITCase - k8sBuild - k8s:build, should create image [✓] VertxK8sITCase - k8sBuild - k8s:build, should create image [✓] ThorntailK8sITCase - k8sBuild - k8s:build, should create image [✓] WildflyJarK8sITCase - k8sBuild - k8s:build, should create image [✓] OpenLibertyK8sITCase - k8sBuild - k8s:build, should create image [✓] VertxK8sITCase - k8sResource - k8s:resource, should create manifests [✓] KarafK8sITCase - k8sResource - k8s:resource, should create manifest for Kubernetes [✓] ThorntailK8sITCase - k8sResource - k8s:resource, should create manifests [✓] OpenLibertyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] WildflyJarK8sITCase - k8sResource - k8s:resource, should create manifests [✓] VertxK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] VertxK8sITCase - k8sLog - k8s:log, should retrieve log [✓] KarafK8sITCase - K8sApply - k8s:apply, should apply manifests on k8s cluster [✓] DslK8sGradleITCase - k8sBuild - k8sBuild, should create image [✓] VertxK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] DslK8sGradleITCase - k8sResource - k8sResource, should create manifests [✓] DslK8sGradleITCase - k8sHelm - k8sHelm, should create Helm charts [✓] KarafK8sITCase - k8sLog - k8s:log [✓] KarafK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ThorntailK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ThorntailK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] OpenLibertyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] OpenLibertyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] OpenLibertyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] WildflyJarK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] DslK8sGradleITCase - k8sApply - k8sApply, should deploy pod and service [✓] DslK8sGradleITCase - k8sLog - k8sLog, should retrieve log [✓] DslK8sGradleITCase - k8sUndeploy - k8sUndeploy, should delete all applied resources [✓] WildflyJarK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (4) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.25.4-quarkus)
[✓] QuarkusK8sITCase - k8sBuild - k8s:build, should create image [✓] QuarkusK8sITCase - k8sResource - k8s:resource, should create manifests [✓] QuarkusK8sITCase - k8sHelm - k8s:helm, should create Helm charts [✓] QuarkusK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] QuarkusK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.25.4-quarkus-native)
[✓] QuarkusNativeK8sITCase - k8sBuild - k8s:build, should create image [✓] QuarkusNativeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] QuarkusNativeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] QuarkusNativeK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] All tests (4) passed successfully!!!:x: Test reports (Minikube v1.25.4-springboot)
[✓] HelmConfigITCase - k8sResource - k8s:resource, no specified profile, should create default resource manifests [✓] CustomResourceK8sITCase - k8sBuild - k8s:build, should create image [X] CompleteK8sITCase - k8sBuild - k8s:build, should create image [X] ZeroConfigK8sITCase - k8sBuild - k8s:build, should create layered jar image [✓] ZeroConfigFatJarK8sITCase - k8sBuild - k8s:build, should create fat jar image [✓] CompleteDockerITCase - k8sBuild - k8s:build, should create image and assembly files [✓] HelmConfigITCase - k8sHelm - k8s:helm, should create Helm charts [✓] ZeroConfigFatJarK8sITCase - k8sResource - k8s:resource, should create manifests [✓] CompleteK8sJibITCase - k8sBuild - k8s:build, should create JIB image [✓] CompleteK8sITCase - k8sResource - k8s:resource, should create manifests [X] HelmConfigITCase - k8sHelmPush - k8s:helm-push, should push the charts [✓] ZeroConfigK8sITCase - k8sPush - k8s:push, should push image to remote registry [✓] CustomResourceK8sITCase - k8sPush - k8s:push, should push image to remote registry [✓] ZeroConfigFatJarK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CompleteK8sJibITCase - k8sResource - k8s:resource, should create manifests [✓] CompleteDockerITCase - k8sResource - k8s:resource, should create manifests in specific directory [✓] ZeroConfigK8sITCase - k8sResource - k8s:resource, should create manifests [✓] ZeroConfigFatJarK8sITCase - k8sLog - k8s:log, should retrieve log [✓] CustomResourceK8sITCase - k8sResource - k8s:resource, should create manifests [✓] CompleteK8sJibITCase - k8sPush - k8s:push, should push image to remote registry [✓] ZeroConfigK8sITCase - k8sHelm - k8s:helm, should create Helm charts [✓] ZeroConfigFatJarK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [X] ZeroConfigK8sGradleITCase - k8sBuild - k8sBuild, should create image [X] ZeroConfigK8sGradleITCase - k8sResource - k8sResource, should create manifests [X] ZeroConfigK8sGradleITCase - k8sHelm - k8sHelm, should create Helm charts [X] ZeroConfigK8sGradleITCase - k8sPush - k8sPush, should push image to remote registry [X] CompleteK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CompleteK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] CompleteDockerITCase - k8sApply - k8s:apply, should deploy pod and service form manifests in specific directory [✓] CompleteDockerITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] CustomResourceK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CustomResourceK8sITCase - k8sLog - k8s:log, should retrieve log [✓] CustomResourceK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] CompleteK8sJibITCase - k8sApply - k8s:apply, should deploy pod and service [✓] CompleteK8sJibITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ZeroConfigK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [X] ZeroConfigK8sGradleITCase - k8sApply - k8sApply, should deploy pod and service [X] ZeroConfigK8sGradleITCase - k8sLog - k8sLog, should retrieve log [✓] ZeroConfigK8sGradleITCase - k8sUndeploy - k8sUndeploy, should delete all applied resources [✓] All tests (6) passed successfully!!!:heavy_check_mark: Test reports (Minikube v1.25.4-webapp)
[✓] JettyK8sITCase - k8sBuild - k8s:build, should create image [✓] ZeroConfigK8sITCase - k8sBuild - k8s:build, should create image [✓] TomcatJakartaeeK8sITCase - k8sBuild - k8s:build should display the Tomcat webapps dir hint by default [✓] TomcatJavaeeK8sITCase - k8sBuild - k8s:build should display the Tomcat webapps dir hint by default [✓] WildFlyK8sITCase - k8sBuild - k8s:build, should create image [✓] JettyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] ZeroConfigK8sITCase - k8sResource - k8s:resource, should create manifests [✓] TomcatJakartaeeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] TomcatJavaeeK8sITCase - k8sResource - k8s:resource, should create manifests [✓] WildFlyK8sITCase - k8sResource - k8s:resource, should create manifests [✓] JettyK8sWatchITCase - k8sWatchCopy - k8s:watch, with mode=copy, SHOULD hot deploy the application [✓] JettyK8sWatchITCase - k8sWatchNone - k8s:watch, with mode=none, SHOULD NOT hot deploy the application [✓] JettyK8sWatchITCase - k8sWatchBuildAndRun - k8s:watch, with mode=both, SHOULD hot deploy the application [✓] JettyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] JettyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] JettyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] ZeroConfigK8sITCase - k8sLog - k8s:log, should retrieve log [✓] ZeroConfigK8sITCase - testNodePortResponse - Service as NodePort response should return String [✓] TomcatJakartaeeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] ZeroConfigK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] TomcatJavaeeK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] WildFlyK8sITCase - k8sApply - k8s:apply, should deploy pod and service [✓] WildFlyK8sITCase - k8sLog - k8s:log, should retrieve log [✓] TomcatJakartaeeK8sITCase - k8sLog - k8s:log, should retrieve log with migration notice [✓] TomcatJakartaeeK8sITCase - testJakartaeeNodePortResponse - The JakartaEE servlet, exposed as a NodePort Service, should return a string and contain `Hello World` [✓] WildFlyK8sITCase - k8sUndeploy - k8s:undeploy, should delete all applied resources [✓] TomcatJavaeeK8sITCase - k8sLog - k8s:log, should retrieve log with migration notice [✓] TomcatJakartaeeK8sITCase - k8sUndeployJakartaEE - k8s:undeploy, should delete all applied resources [✓] TomcatJavaeeK8sITCase - testJavaeeNodePortResponse - The JavaEE servlet, exposed as a NodePort Service, should return a string and contain `Hello World` [✓] TomcatJavaeeK8sITCase - k8sUndeployJavaEE - k8s:undeploy, should delete all applied resources [✓] TomcatJakartaeeK8sITCase - k8sBuildWithWebappEnv - k8s:build, with jkube.generator.webapp.env should not display the Tomcat webapps dir hint [✓] TomcatJavaeeK8sITCase - k8sBuildWithWebappEnv - k8s:build, with jkube.generator.webapp.env should not display the Tomcat webapps dir hint [✓] TomcatJakartaeeK8sITCase - k8sApplyWithNewDeployment - k8s:apply, should deploy pod and service with new image [✓] TomcatJakartaeeK8sITCase - testJakartaEENodePortResponse - JakartaEE Service as NodePort response should return String [✓] TomcatJavaeeK8sITCase - k8sApplyWithNewDeployment - k8s:apply, should deploy pod and service with new image [✓] TomcatJakartaeeK8sITCase - k8sLogWithoutJavaeeMigrationNotice - k8s:log, should retrieve log without JavaEE migration notice [✓] TomcatJakartaeeK8sITCase - finalK8sUndeploy - Final k8s:undeploy, should delete all applied resources [✓] TomcatJavaeeK8sITCase - k8sLogWithoutJavaeeMigrationNotice - k8s:log, should retrieve log without JavaEE migration notice [✓] TomcatJavaeeK8sITCase - testJavaEENodePortResponseError - JavaEE Service as NodePort response should return 500 and java.lang.NoClassDefFoundError message [✓] TomcatJavaeeK8sITCase - finalK8sUndeploy - Final k8s:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (OpenShift v3.11.0-other)
[✓] DslOcGradleITCase - ocBuild - ocBuild, should create image [✓] DslOcGradleITCase - ocResource - ocResource, should create manifests [✓] OpenLibertyOcITCase - ocBuild - oc:build, should create image [✓] OpenLibertyOcITCase - ocResource - oc:resource, should create manifests [✓] VertxOcITCase - ocBuild - oc:build, should create image [✓] VertxOcITCase - ocResource - oc:resource, should create manifests [✓] WildflyJarOcITCase - ocBuild - oc:build, should create image [✓] WildflyJarOcITCase - ocResource - oc:resource, should create manifests [✓] ThorntailOcITCase - ocBuild - oc:build, should create image [✓] ThorntailOcITCase - ocResource - oc:resource, should create manifests [✓] KarafOcITCase - ocBuild - oc:build, should create image [✓] KarafOcITCase - ocResource - oc:resource, should create resource manifests [✓] DslOcGradleITCase - ocApply - ocApply, should deploy pod and service [✓] DslOcGradleITCase - ocHelm - ocHelm, should create Helm charts [✓] DslOcGradleITCase - ocLog - ocLog, should retrieve log [✓] DslOcGradleITCase - ocUndeploy - ocUndeploy, should delete all applied resources [✓] OpenLibertyOcITCase - ocApply - oc:apply, should deploy pod and service [✓] OpenLibertyOcITCase - ocLog - oc:log, should retrieve log [✓] VertxOcITCase - ocApply - oc:apply, should deploy pod and service [✓] OpenLibertyOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] VertxOcITCase - k8sLog - oc:log, should retrieve log [✓] VertxOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] WildflyJarOcITCase - ocApply - oc:apply, should deploy pod and service [✓] WildflyJarOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] ThorntailOcITCase - ocApply - oc:apply, should deploy pod and service [✓] ThorntailOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] KarafOcITCase - ocApply - oc:apply, should create pod, service and route [✓] KarafOcITCase - ocLog - oc:log, should retrieve log [✓] KarafOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (OpenShift v3.11.0-quarkus)
[✓] QuarkusOcITCase - ocBuild - oc:build, should create image [✓] QuarkusOcITCase - ocResource - oc:resource, should create manifests [✓] QuarkusOcITCase - ocHelm - oc:helm, should create Helm charts [✓] QuarkusOcITCase - ocApply - oc:apply, should deploy pod and service [✓] QuarkusOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:x: Test reports (OpenShift v3.11.0-springboot)
[✓] HelmConfigITCase - ocResource - oc:resource, no specified profile, should create default resource manifests [✓] HelmConfigITCase - ocHelm - oc:helm, should create Helm charts [X] HelmConfigITCase - ocHelmPush - oc:helm-push, should push the charts [✓] ZeroConfigOcITCase - ocBuild - oc:build, should create image [✓] ZeroConfigOcITCase - ocResource - oc:resource, should create manifests [✓] WatchOcITCase - watch_whenSourceModified_shouldLiveReloadChanges - watch, SHOULD hot reload application on changes [X] ZeroConfigOcGradleITCase - ocBuild - ocBuild, should create image [X] ZeroConfigOcGradleITCase - ocResource - ocResource, should create manifests [✓] ZeroConfigOcITCase - ocApply - oc:apply, should deploy pod and service [✓] ZeroConfigOcITCase - ocHelm - oc:helm, should create Helm charts [✓] ZeroConfigOcITCase - ocLog - oc:log, should retrieve log [✓] ZeroConfigOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [X] ZeroConfigOcGradleITCase - ocApply - ocApply, should deploy pod and service [X] ZeroConfigOcGradleITCase - ocHelm - ocHelm, should create Helm charts [X] ZeroConfigOcGradleITCase - ocLog - ocLog, should retrieve log [✓] ZeroConfigOcGradleITCase - ocUndeploy - ocUndeploy, should delete all applied resources [X] Some tests did not pass (Failed tests 5/6):heavy_check_mark: Test reports (OpenShift v3.11.0-webapp)
[✓] WildFlyOcITCase - ocBuild - oc:build, should create image [✓] WildFlyOcITCase - ocResource - oc:resource, should create manifests [✓] ZeroConfigOcITCase - ocBuild - oc:build, should create image [✓] ZeroConfigOcITCase - ocResource - oc:resource, should create manifests [✓] WildFlyOcDockerModeITCase - ocBuild - oc:build, should create image using docker [✓] WildFlyOcDockerModeITCase - ocResource - k8s:resource, should create manifests [✓] JettyOcITCase - ocBuild - oc:build, should create image [✓] JettyOcITCase - ocResource - oc:resource, should create manifests [✓] WildFlyOcITCase - ocApply - oc:apply, should deploy pod and service [✓] WildFlyOcITCase - ocLog - oc:log, should retrieve logs [✓] ZeroConfigOcITCase - ocApply - oc:apply, should deploy pod and service [✓] ZeroConfigOcITCase - testNodePortResponse - Service as NodePort response should return String [✓] WildFlyOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] ZeroConfigOcITCase - ocLog - oc:log, should retrieve log [✓] ZeroConfigOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] WildFlyOcDockerModeITCase - ocApply - oc:apply, should deploy pod and service [✓] WildFlyOcDockerModeITCase - ocLog - oc:log, should retrieve logs [✓] JettyOcITCase - ocApply - oc:apply, should deploy pod and service [✓] WildFlyOcDockerModeITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] JettyOcITCase - ocLog - oc:log, should retrieve log [✓] JettyOcITCase - ocUndeploy - oc:undeploy, should delete all applied resources [✓] All tests (5) passed successfully!!!:heavy_check_mark: Test reports (Windows)
[✓] WindowsITCase - k8sBuild - k8s:build, should create image [✓] WindowsITCase - k8sPush - k8s:push, should push image to remote registry [✓] WindowsITCase - k8sResource - k8s:resource, should create manifests [✓] WindowsITCase - ocResource - oc:resource, should create manifests [✓] WindowsITCase - k8sHelm - k8s:helm, should create Helm charts [✓] WindowsITCase - ocHelm - oc:helm, should create Helm charts [✓] All tests (6) passed successfully!!!
Codecov Report
Merging #2245 (84b8441) into master (1ac4f7c) will increase coverage by
0.50%. Report is 82 commits behind head on master. The diff coverage is82.17%.
:exclamation: Current head 84b8441 differs from pull request most recent head 528af16. Consider uploading reports for the commit 528af16 to get more accurate results
@@ Coverage Diff @@
## master #2245 +/- ##
============================================
+ Coverage 59.36% 59.86% +0.50%
- Complexity 4586 4611 +25
============================================
Files 500 505 +5
Lines 21211 21043 -168
Branches 2830 2785 -45
============================================
+ Hits 12591 12597 +6
+ Misses 7370 7231 -139
+ Partials 1250 1215 -35
| Files Changed | Coverage Δ | |
|---|---|---|
| ...eclipse/jkube/kit/config/service/PatchService.java | 38.59% <ø> (-6.46%) |
:arrow_down: |
| .../config/service/kubernetes/DockerBuildService.java | 54.54% <0.00%> (-8.62%) |
:arrow_down: |
| ...kit/config/service/kubernetes/JibBuildService.java | 86.15% <0.00%> (-4.17%) |
:arrow_down: |
| ...e/kit/resource/service/DefaultResourceService.java | 79.24% <ø> (ø) |
|
| ...a/org/eclipse/jkube/kit/common/util/AsyncUtil.java | 48.00% <37.50%> (-4.95%) |
:arrow_down: |
| ...lipse/jkube/kit/config/resource/MappingConfig.java | 81.81% <50.00%> (+1.81%) |
:arrow_up: |
| ...kube/springboot/generator/SpringBootGenerator.java | 92.50% <75.00%> (+47.64%) |
:arrow_up: |
| ...e/jkube/kit/resource/helm/HelmUploaderManager.java | 77.77% <77.77%> (ø) |
|
| .../kit/resource/helm/StandardRepositoryUploader.java | 82.14% <82.14%> (ø) |
|
| ...ipse/jkube/springboot/SpringBootDevtoolsUtils.java | 82.79% <82.79%> (ø) |
|
| ... and 7 more |
... and 8 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Kudos, SonarCloud Quality Gate passed! 
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
0.0% Coverage
0.0% Duplication
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
Sun is on PTO. However, did Rohan approve based on the changes you made? (if not, please don't ask someone else to 'merge')
Sun is on PTO. However, did Rohan approve based on the changes you made? (if not, please don't ask someone else to 'merge')
I made the changes that he suggested. Didn't get a reply from @rohanKanojia on this. I'll check with him again.
Don't worry. I spoke with him yesterday. He will review when available. Just making sure we do not miss addressing comments.
I tested it on DockerHub, Quay.io and GitHub Container Registry, it seems to be working okay.
I think if a user gets unauthorized error, there are two possibilities:
- User has image name configured wrong (needs to change image name, update registry etc)
- User is providing invalid credentials (need to provide/update credentials)
I think we should print two hints instead of one.
Could you please add some unit tests for this? Maybe we should try to move this logic to some common place to avoid duplication.
TODO for this issue: debug with docker and jib, extract the error and create unit test based on the extracted error.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
0.0% Coverage
0.0% Duplication
The version of Java (11.0.18) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here