jkube icon indicating copy to clipboard operation
jkube copied to clipboard

Merge ResourceConfig's `serviceAccount` and `serviceAccounts` configuration options

Open rohanKanojia opened this issue 1 year ago • 0 comments

Component

JKube Kit

Task description

Description

We seem to have two fields in ResourceConfig for configuring ServiceAccounts:

  • serviceAccount - accepts ServiceAccount name only
  • serviceAccounts - list with each element accepting ServiceAccount name and Deployment to bind it to

This can be a bit confusing for users and it doesn't provide fine-grained control over things like:

  • binding ServiceAccount to all controllers
  • binding ServiceAccount to specific controller only
  • whether to generate new ServiceAccount or not

We might want to deal with the ResourceConfig pojo and maybe remove the getServiceAccount getter, or evaluate how both configurations should be merged.

Originally posted by @manusa in https://github.com/eclipse/jkube/issues/1758#issuecomment-1302138214

rohanKanojia avatar Jun 08 '23 10:06 rohanKanojia