jkube icon indicating copy to clipboard operation
jkube copied to clipboard

Update AutoTLSEnricher's volume mount path locations to use updated jkube domains

Open rohanKanojia opened this issue 2 years ago • 1 comments

Component

JKube Kit

Task description

Description

Related to https://github.com/eclipse/jkube/issues/1273

:construction: Requires https://github.com/eclipse/jkube/pull/1995 to get merged first

We changed JKubeAnnotations to have jkube.eclipse.org prefix instead of jkube.io. But there are still some places where jkube.io is still getting used. It's not in form of annotations, but in form of volume mount points: https://github.com/eclipse/jkube/blob/8db1fe14e9dfe7321bd00d68fd508f4e82a61822/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/AutoTLSEnricher.java#L55 https://github.com/eclipse/jkube/blob/8db1fe14e9dfe7321bd00d68fd508f4e82a61822/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/openshift/AutoTLSEnricher.java#L57

We should update these to use jkube.eclipse.org instead.

Expected Behavior

Mount points should have jkube.eclipse.org in them instead of jkube.io

Acceptance Criteria

  • [ ] AutoTLSEnricher tlsSecretVolumeMountPoint and jksVolumeMountPoint should have default values containing updated jkube prefixes jkube.eclipse.org
  • [ ] Users should be allowed to use older prefixes if they want
  • [ ] Tests should be updated to use new prefixes

rohanKanojia avatar Feb 23 '23 06:02 rohanKanojia

Can't we just use jkube instead of a fully qualified domain name? Is there any specific reason to use such convention here?

manusa avatar Mar 07 '23 10:03 manusa