jkube icon indicating copy to clipboard operation
jkube copied to clipboard

OpenShift Maven|Gradle Plugin should use Deployments by default

Open manusa opened this issue 2 years ago • 2 comments

Description

We should switch OpenShift Maven|Gradle plugins to create Deployments instead of DeploymentConfigs (DC) by default. The application should behave as if the jkube.build.switchToDeployment was defaulted to true. Users should be able to still use DCs by setting that property to false or by setting any of the other related properties/configurations that set the kind of controller to be built.

Update 2024-01-25

OpenShift officially deprecates the usage of DeploymentConfigs in version 4.14 (see https://access.redhat.com/articles/7041372)

This has been already tackled by Quarkus (https://github.com/quarkusio/quarkus/pull/37229)

To be able to properly support image streams, we need to add the following annotation to the Pod template (as documented in https://docs.openshift.com/container-platform/4.14/openshift_images/using-imagestreams-with-kube-resources.html):

alpha.image.policy.openshift.io/resolve-names: '*'

Relates to:

  • #630
  • #667

/cc @rgordill :pray:

manusa avatar Oct 18 '22 10:10 manusa

Related discussion https://github.com/fabric8io/fabric8-maven-plugin/issues/1042 on Fabric8 Maven Plugin

rohanKanojia avatar Nov 22 '22 10:11 rohanKanojia

There seems to be recent effort involved in maintaining the S2I build approach, so it might make sense to delay this change until there's a clear vision on the future of S2I.

manusa avatar Feb 15 '23 10:02 manusa