jkube icon indicating copy to clipboard operation
jkube copied to clipboard

[Hacktoberfest] LogOutputSpecFactory fields may be 'final'

Open manusa opened this issue 1 year ago • 1 comments

Description

The following statements are reported as a code style issue:

https://github.com/eclipse/jkube/blob/053e63e095222c26994984f73a4a4603f5489ef7/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/access/log/LogOutputSpecFactory.java#L31-L33

  • [ ] should be changed to:
    private final boolean useColor;
    private final boolean logStdout;
    private final String logDate;

Before you start

Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console. (Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

manusa avatar Oct 13 '22 07:10 manusa

Hello , I can help out in this can you assigned it to me?

Kumar-Rishav-py avatar Oct 13 '22 18:10 Kumar-Rishav-py

Hi, Plz assign this issue to me.

sam2611 avatar Oct 26 '22 13:10 sam2611