jkube
jkube copied to clipboard
[Hacktoberfest] ImagePullCache fields may be 'final'
Description
The following statement is reported as a code style issue:
https://github.com/eclipse/jkube/blob/c15c4bb8b7cc4ea7502f8314b1e067b27f9a1dda/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/ImagePullCache.java#L27
- [ ] should be changed to:
private final Backend backend;
Before you start
Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.
How to manually test my changes
Kubernetes
If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.
- Minikube get started guide
- Kind (Requires Docker) quick start
OpenShift
If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.
Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console.
(Press the ?
icon and from the context menu select Command line tools
, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)
Hi, @manusa can you assign me to this issue too? 😅
Just one first-timer issue per new contributor ;)
Hi @manusa, can you assign this issue to me?
hey @ChinmayaSharma-hue if you are not working on this can I give it a try @manusa, @rohanKanojia can you assign this issue to me
hey @manusa i have created a pr https://github.com/eclipse/jkube/pull/1957 can you review and merge it