jkube icon indicating copy to clipboard operation
jkube copied to clipboard

[Hacktoberfest] ImagePullCache fields may be 'final'

Open manusa opened this issue 2 years ago • 3 comments

Description

The following statement is reported as a code style issue:

https://github.com/eclipse/jkube/blob/c15c4bb8b7cc4ea7502f8314b1e067b27f9a1dda/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/ImagePullCache.java#L27

  • [ ] should be changed to:
    private final Backend backend;

Before you start

Make sure you read the contributing guide first. Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

How to manually test my changes

Kubernetes

If you don't have a real Kubernetes cluster available (most probably), you can use Minikube or Kind to test with a local cluster.

OpenShift

If you don't have a real OpenShift cluster available (most probably), you can use Red Hat's developer Sandbox for Red Hat OpenShift. The only requirement is to have a Red Hat account.

Once you have your Sandbox environment, you'll need to download the oc tool from the cluster console. (Press the ? icon and from the context menu select Command line tools, you'll be redirected to https://$subdomain.openshiftapps.com/command-lines-tools where you'll be able to download the CLI for your platform)

manusa avatar Oct 10 '22 07:10 manusa

Hi, @manusa can you assign me to this issue too? 😅

jhonDoe15 avatar Oct 10 '22 10:10 jhonDoe15

Just one first-timer issue per new contributor ;)

manusa avatar Oct 10 '22 11:10 manusa

Hi @manusa, can you assign this issue to me?

ChinmayaSharma-hue avatar Oct 10 '22 18:10 ChinmayaSharma-hue

hey @ChinmayaSharma-hue if you are not working on this can I give it a try @manusa, @rohanKanojia can you assign this issue to me

prak30 avatar Dec 07 '22 03:12 prak30

hey @manusa i have created a pr https://github.com/eclipse/jkube/pull/1957 can you review and merge it

prak30 avatar Dec 07 '22 17:12 prak30