jkube icon indicating copy to clipboard operation
jkube copied to clipboard

(jkube-kit/enricher/generic/) : Migrate tests from JMockit to Mockito

Open rohanKanojia opened this issue 2 years ago • 0 comments

Component

JKube Kit

Task description

Description

Child of https://github.com/eclipse/jkube/issues/857

Migrate the following tests to use Mockito instead of JMockit:

  • ConfigMapEnricherTest
  • ContainerEnvJavaOptionsMergeTest
  • ContainerEnvJavaOptionsMergeVisitorTest
  • DebugEnricherTest
  • DefaultMetadataEnricherTest
  • DefaultServiceEnricherAddMissingPartsTest
  • DefaultServiceEnricherTest
  • DependencyEnricherTest
  • DockerRegistrySecretEnricherTest
  • FileDataSecretEnricherTest
  • ImageEnricherTest
  • IngressEnricherTest
  • MavenIssueManagementEnricherTest
  • MavenProjectEnricherTest
  • MavenScmEnricherTest
  • NetworkingV1IngressGeneratorTest
  • PortNameEnricherTest
  • ProjectLabelEnricherTest
  • RevisionHistoryEnricherTest
  • ServiceAccountEnricherTest
  • TriggersAnnotationEnricherTest
  • VolumePermissionEnricherTest
  • AutoTLSEnricherTest
  • DeploymentConfigEnricherTest
  • ImageChangeTriggerEnricherTest
  • RouteEnricherTest

Expected Behavior

All tests in the abovementioned need to be migrated to mockito. All references to jmockit should be removed or replaced with Mockito equivalents.

Acceptance Criteria

  • [ ] tests should be migrated to mockito
  • [ ] Dependency org.jmockit:jmockit should be removed from pom.xml
  • [ ] Assertions should be replaced by AssertJ
  • [ ] Tests should be evaluated and refactored if applicable (optional)

rohanKanojia avatar Jun 14 '22 13:06 rohanKanojia