eclipse.jdt.ls
eclipse.jdt.ls copied to clipboard
ls support for inherited document symbols
New extension is added to support reading inherited document symbols from java language server.
Can one of the admins verify this patch?
@rgrunber please have a look at the patch and let me know what you think ?
Overall, it worked well.
I have some feedback regarding to UX:
- Only show actual inherit members In this screenshot, I'm viewing the extended outline for a record class, the view shows two
toString()
from different super classes. It would be better to hide the one fromjava.lang.Object
, since it's overridden by the subclassjava.lang.record
You mean to only show the top most declaration/override of a method in the class hierarchy ?
- Better support constructors I think what we missed here is the constructor
Student(String, String)
. Personally I think there is no need to show the constructors from the super types.
You mean not to show any of the super type constructors other than the current type's ones ?
You mean to only show the top most declaration/override of a method in the class hierarchy?
Yes, my thought is that, displaying the methods that are overridden provides very limited help but makes the view crowded.
You mean not to show any of the super type constructors other than the current type's ones?
Yes.
BTW, they are all my personal opinions about the UX. We can discuss if you have different opinions
will redo this since the code has diverged alot