eclipse.jdt.ls icon indicating copy to clipboard operation
eclipse.jdt.ls copied to clipboard

ls support for inherited document symbols

Open gayanper opened this issue 1 year ago • 2 comments

New extension is added to support reading inherited document symbols from java language server.

gayanper avatar Jul 22 '22 13:07 gayanper

Can one of the admins verify this patch?

eclipse-ls-bot avatar Jul 22 '22 13:07 eclipse-ls-bot

@rgrunber please have a look at the patch and let me know what you think ?

gayanper avatar Jul 22 '22 14:07 gayanper

Overall, it worked well.

I have some feedback regarding to UX:

  1. Only show actual inherit members image In this screenshot, I'm viewing the extended outline for a record class, the view shows two toString() from different super classes. It would be better to hide the one from java.lang.Object, since it's overridden by the subclass java.lang.record

You mean to only show the top most declaration/override of a method in the class hierarchy ?

  1. Better support constructors image I think what we missed here is the constructor Student(String, String). Personally I think there is no need to show the constructors from the super types.

You mean not to show any of the super type constructors other than the current type's ones ?

gayanper avatar Nov 26 '22 20:11 gayanper

You mean to only show the top most declaration/override of a method in the class hierarchy?

Yes, my thought is that, displaying the methods that are overridden provides very limited help but makes the view crowded.

You mean not to show any of the super type constructors other than the current type's ones?

Yes.

BTW, they are all my personal opinions about the UX. We can discuss if you have different opinions

jdneo avatar Nov 28 '22 00:11 jdneo

will redo this since the code has diverged alot

gayanper avatar Jun 04 '23 09:06 gayanper