eclipse.jdt.ls icon indicating copy to clipboard operation
eclipse.jdt.ls copied to clipboard

Hide completions when signature help is enabled

Open fvclaus opened this issue 3 years ago • 6 comments

Signed-off-by: Frederik Claus [email protected]

Implementation for https://github.com/redhat-developer/vscode-java/issues/2063

fvclaus avatar Sep 24 '21 17:09 fvclaus

Can one of the admins verify this patch?

eclipse-ls-bot avatar Sep 24 '21 17:09 eclipse-ls-bot

@Eskibear can you please look at the code and decide if we can move forward with it or not?

fvclaus avatar Oct 11 '21 15:10 fvclaus

This doesn't seem to have an impact in vscode. I can see the filter text is simplified, but it still shows all completions, shows and inserts all parameters for an overloaded method.

fbricon avatar Oct 12 '21 13:10 fbricon

add to whitelist

fbricon avatar Oct 12 '21 13:10 fbricon

@fbricon When the filter text is used, vscode will hide completions once the ( is entered: jdt_ls_hide_completions Without the filter text, vscode will show the completions that match the text being entered: jdt_ls_show_completions

fvclaus avatar Oct 14 '21 09:10 fvclaus

For this to work, the signatureHelp needs to be active:

"java.signatureHelp.enabled": true,

fvclaus avatar Oct 14 '21 09:10 fvclaus