iceoryx icon indicating copy to clipboard operation
iceoryx copied to clipboard

Cleanup or Remove ObjectPool

Open elfenpiff opened this issue 4 years ago • 5 comments

Brief feature description

The object pool is in a very early stage and should be refactored/cleaned up or it should be removed. At the moment it is used nowhere.

Steps

  1. If ObjectPool is not needed - remove it. If needed, perform the rest of the steps
  2. follow up every todo and fix it.
  3. move implementation from header (hpp) into inline (inl) file
  4. cleanup unit tests (small unit tests with one or two EXPECT_*) with an behavior driven approach.

elfenpiff avatar Mar 20 '20 08:03 elfenpiff

@elfenpiff What is the current status? How much effort is this?

@ithier Why are you using this in the DDS gateway?

mossmaurice avatar Nov 04 '20 15:11 mossmaurice

This is linked to #488 where an uninitialized_array is used, please clarify first if the Objectpool is maybe obsolete.

dkroenke avatar Jan 29 '21 09:01 dkroenke

I use this in the gateway implementation as a place for the gateway to create publishers/subscribers/data readers/data writers when doing dynamic discovery. See here: https://github.com/eclipse-iceoryx/iceoryx/blob/master/iceoryx_posh/include/iceoryx_posh/gateway/channel.hpp#L82

We would either need another solution for this or to not support dynamic topic discovery if we wanted to remove the object pool.

orecham avatar Feb 02 '21 23:02 orecham

I think something like the ObjectPool is needed. Maybe with some refactoring and consolidation what we created after the ObjectPool.

elBoberido avatar Feb 03 '21 14:02 elBoberido

@elfenpiff What do you think, how should we continue here?

budrus avatar Jan 07 '22 18:01 budrus