Fix Bzlmod module name typo
Notes for Reviewer
Currently if you want to depend on Iceoryx as a Bzlmod bazel_dep you have to do something like
bazel_dep(name = "org_eclipse_iceroyx", repo_name = "iceoryx")
git_override(
module_name = "org_eclipse_iceroyx",
commit = "00c5349eabfb1bce5db46efefb39fd9471679be1",
patches = ["//third_party/iceoryx:iceoryx.patch"],
remote = "https://github.com/eclipse-iceoryx/iceoryx",
)
It would be nice to fix that typo.
I'll send some follow up PRs to contribute patches that make depending on the module via Bzlmod actually work.
Pre-Review Checklist for the PR Author
- [x] Code follows the coding style of CONTRIBUTING.md
- [x] Tests follow the best practice for testing
- [x] Changelog updated in the unreleased section including API breaking changes
- [x] Branch follows the naming format (
iox-123-this-is-a-branch) - [x] Commits messages are according to this guideline
- [x] Commit messages have the issue ID (
iox-#123 commit text) - [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
- [x] Commit messages have the issue ID (
- [x] Update the PR title
- Follow the same conventions as for commit messages
- Link to the relevant issue
- [x] Relevant issues are linked
- [x] Add sensible notes for the reviewer
- [x] All checks have passed (except
task-list-completed) - [x] Assign PR to reviewer
Checklist for the PR Reviewer
- [ ] Consider a second reviewer for complex new features or larger refactorings
- [ ] Commits are properly organized and messages are according to the guideline
- [ ] Code according to our coding style and naming conventions
- [ ] Unit tests have been written for new behavior
- [ ] Public API changes are documented via doxygen
- [ ] Copyright owner are updated in the changed files
- [ ] All touched (C/C++) source code files from
iceoryx_hoofshave been added to./clang-tidy-diff-scans.txt - [ ] PR title describes the changes
Post-review Checklist for the PR Author
- [x] All open points are addressed and tracked via issues
References
- Closes #2364
@lalten Thanks for the contribution. Since we are an open source project under the eclipse foundation you need to sign the ECA: https://www.eclipse.org/legal/eca/
We are targeting mission-critical systems and this requires that every change in the repo must be connected to an issue. So could you please create an issue.
Also every commit must have the prefix iox-#??? where ??? is the issue number.
@elfenpiff please have another look.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.71%. Comparing base (
fc86354) to head (3978c63). Report is 3 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2363 +/- ##
==========================================
+ Coverage 78.69% 78.71% +0.01%
==========================================
Files 440 440
Lines 16981 16981
Branches 2361 2361
==========================================
+ Hits 13364 13366 +2
+ Misses 2736 2735 -1
+ Partials 881 880 -1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 78.51% <ø> (+0.01%) |
:arrow_up: |
| unittests_timing | 15.35% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
@lalten Looks good. I created this issue #2364 for you. Could you please adjust your commit message so that the prefix is iox-#2364 - then we can merge this PR.
@elfenpiff anything left to do on my side for this PR?
@lalten can you please rebase? We deactivated the Cirrus CI on main since we ran out of credits for the open source project.
@lalten thanks for your contribution and sorry letting you wait so long with the merge :)