iceoryx icon indicating copy to clipboard operation
iceoryx copied to clipboard

typo fix: paramater --> parameter

Open GerHobbelt opened this issue 1 year ago • 2 comments

Notes for Reviewer

As it says on the tin. Just a very minor English language tidbit.

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of [CONTRIBUTING.md][contributing]
  2. [x] Add sensible notes for the reviewer

GerHobbelt avatar Aug 19 '24 16:08 GerHobbelt

@GerHobbelt since we are an Eclipse project, you need to sign the ECA. Without that, we can not merge the PR.

Also, since iceoryx is used in a safety critical environment we have to follow rules for traceability. One of the rules is that the commit message must have the issue number of the related issue at the front. Usually, we have to create an issue first before we create commits but for such small changes you can use #2305. Can you please change the commit message to

iox-#3205 Typo fix: paramater -> parameter

And also add

Relates to #2305

to the bottom of the PR description

elBoberido avatar Aug 19 '24 18:08 elBoberido

@GerHobbelt are you planing to continue on this? If not, I would fix the typo with one of my next PRs.

elBoberido avatar Oct 29 '24 18:10 elBoberido