Replace 'iox::string' with semantically appropriate types like `FilePath`
Brief feature description
In many places an iox::string is used instead of a semantically more appropriate type like FilePath. In order to prevent superfluous checks and easy to make mistakes the semantically appropriate type shall be used.
See also https://github.com/eclipse-iceoryx/iceoryx/pull/2016#discussion_r1315024006
Detailed information
Tasks
- [ ] Check the usage of
iox::stringin the API - [ ] Replace
iox::stringwithFileName,UserName,GroupName,FilePathandPath - [ ] Use
FileNameforRuntineName_t, which is aniox::stringalias - [ ] Use
FileNamefordetail::PosixSharedMemory::Name_t, which is aniox::stringalias
@elfenpiff FYI
Hi @elBoberido ,
I would like to take this issue if it's okay. I am currently reading about the project and it's architecture so it might take a few days. Also I will ask the questions here if it's okay.
Thanks.
@varuntumbe sure, go ahead :)
A good starting point are MessageQueue, NamedPipe and UnixDomainSocket. I would suggest to start with UnixDomainSocketBuilderNoPathPrefix to get an idea of our PR workflow. There is a formalism to follow due to this project being used in safety critical environments which requires traceability of the source code.
UnixDomainSocketBuilder, NamedPipeBuilder and UnixDomainSocketBuilder need to be changed all at once since they are used for the IpcChannel. This might require some deeper understanding.
You can of course also look for other places where currently a iox::string is used and a semantic string might make more sense.