iceoryx icon indicating copy to clipboard operation
iceoryx copied to clipboard

getopt_long is not implemented in windows

Open wukongiii opened this issue 2 years ago • 10 comments

Brief feature description

getopt_long is not implemented in windows

Detailed information

My project needs large buffers, and I followed the configuration document, fill the size it needed, but when I was trying to start iox-roudi.exe with parameter "-c <configuration.location.toml>", it says "getopt_long is not implemented in windows". I have 2 solutions:

  1. Hardcode the size of memory pool in roudi_main_static_config.cpp
  2. Find an open sourced implementation of getopt_long and put it into the project to build a version which can make -c work.

Since I'd like to give my project more flexibilities, I chose solution 2, and it works well. I'd like to make a contribution to the project, but getopt_long is not written by myself, and I don't know the relevant policy of the project, so I have to ask this feature by posting this request.

Thank you.

wukongiii avatar Nov 17 '22 14:11 wukongiii

@wukongiii We are aware of this and this is why we implemented a modern c++ abstraction for command line parsing, see: #1102

We will merge it later this day and based on that I will refactor the command line parsing for the iox-roudi so you should get nice and shiny new command line parsing capabilities on windows.

I will ping you when it is available!

Sadly we cannot go for the getopt_long open source implementation since it is licensed under GPL which is not compatible with Apache 2.0.

elfenpiff avatar Nov 17 '22 14:11 elfenpiff

That's really an exciting news, thank you @elfenpiff ! You guys are awsome!

wukongiii avatar Nov 17 '22 15:11 wukongiii

@elfenpiff given the merge, is this something that will be implemented soon ?

niclar avatar Mar 09 '23 20:03 niclar

@niclar You are right! This is a tiny change now and I will look into it.

elfenpiff avatar Mar 10 '23 15:03 elfenpiff

Hi again, can we expect this to be implemented anytime soon ?

niclar avatar Sep 18 '23 13:09 niclar

@niclar I'm not aware of anybody currently working on this. Patches are welcome :)

elBoberido avatar Sep 19 '23 12:09 elBoberido

alright, we'll start embedding roudi instead...

niclar avatar Sep 25 '23 10:09 niclar

@elBoberido we have merged the command line parser and I thought we already using it in the roudi app. If not we could integrate it there quickly. This would remove a lot of code, and provide an awesome cli interface and we have windows covered with it.

elfenpiff avatar Sep 25 '23 11:09 elfenpiff

@elfenpiff AFAIK we merged the CLI abstraction but did not port RouDi to it. Not sure how simple this would be since it has a layered design with optionally having an option for the path to a TOML config file.

elBoberido avatar Sep 25 '23 12:09 elBoberido

Urge to update!!!

no5-aaron-wu avatar Aug 20 '24 02:08 no5-aaron-wu