WIP:iox-#1394 fix axivion reported violations for relative_pointer

[saif-at-github]

Signed-off-by: shaik saifulla [email protected]

Pre-Review Checklist for the PR Author

1. [x] Code follows the coding style of CONTRIBUTING.md
2. [x] Tests follow the best practice for testing
3. [x] Changelog updated in the unreleased section including API breaking changes
4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
5. [x] Commits messages are according to this guideline
   • [x] Commit messages have the issue ID (iox-#123 commit text)
   • [x] Commit messages are signed (git commit -s)
   • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. [x] Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. [x] Relevant issues are linked
8. [x] Add sensible notes for the reviewer
9. [x] All checks have passed (except task-list-completed)
10. [x] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
11. [x] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

• [ ] Commits are properly organized and messages are according to the guideline
• [ ] Code according to our coding style and naming conventions
• [ ] Unit tests have been written for new behavior
• [ ] Public API changes are documented via doxygen
• [ ] Copyright owner are updated in the changed files
• [ ] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• [ ] PR title describes the changes

Post-review Checklist for the PR Author

1. [ ] All open points are addressed and tracked via issues

References

• Closes TBD

[codecov[bot]]

Codecov Report

Merging #1647 (f1a1162) into master (66b7bb1) will decrease coverage by 0.65%. The diff coverage is 91.30%.

@@            Coverage Diff             @@
##           master    #1647      +/-   ##
==========================================
- Coverage   76.74%   76.08%   -0.66%     
==========================================
  Files         360      364       +4     
  Lines       13888    14159     +271     
  Branches     2298     2376      +78     
==========================================
+ Hits        10658    10773     +115     
- Misses       2459     2589     +130     
- Partials      771      797      +26     

Flag	Coverage Δ
unittests	75.73% <91.30%> (-0.65%)	:arrow_down:
unittests_timing	15.61% <39.13%> (-0.19%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../internal/relocatable_pointer/relative_pointer.inl	100.00% <ø> (ø)
...nternal/relocatable_pointer/pointer_repository.inl	88.88% <77.77%> (+0.25%)	:arrow_up:
...rnal/relocatable_pointer/base_relative_pointer.hpp	100.00% <100.00%> (ø)
.../internal/relocatable_pointer/relative_pointer.hpp	100.00% <100.00%> (ø)
...urce/relocatable_pointer/base_relative_pointer.cpp	83.33% <100.00%> (-0.96%)	:arrow_down:
iceoryx_hoofs/source/posix_wrapper/mutex.cpp	41.70% <0.00%> (-43.60%)	:arrow_down:
...hoofs/include/iceoryx_hoofs/internal/cxx/stack.inl	93.75% <0.00%> (-6.25%)	:arrow_down:
...osh/source/popo/building_blocks/locking_policy.cpp	47.82% <0.00%> (-2.18%)	:arrow_down:
.../include/iceoryx_hoofs/internal/cxx/unique_ptr.inl	95.83% <0.00%> (-0.72%)	:arrow_down:
...include/iceoryx_posh/internal/popo/smart_chunk.inl	100.00% <0.00%> (ø)
... and 6 more

[MatthiasKillat]

This is severely outdated due to refactoring. Should be closed and redone if necessary after the refactoring of relative pointer is complete (if there are still warnings). @mossmaurice