iceoryx
iceoryx copied to clipboard
iox-#1295 Update component and layer diagram for upcoming release
Pre-Review Checklist for the PR Author
- [x] Code follows the coding style of CONTRIBUTING.md
- [x] Tests follow the best practice for testing
- [x] ~~Changelog updated in the unreleased section including API breaking changes~~ No user API changed
- [x] Branch follows the naming format (
iox-123-this-is-a-branch) - [x] Commits messages are according to this guideline
- [x] Commit messages have the issue ID (
iox-#123 commit text) - [x] Commit messages are signed (
git commit -s) - [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
- [x] Commit messages have the issue ID (
- [x] Update the PR title
- Follow the same conventions as for commit messages
- Link to the relevant issue
- [x] Relevant issues are linked
- [x] Add sensible notes for the reviewer
- [x] All checks have passed (except
task-list-completed) - [x] All touched (C/C++) source code files from
iceoryx_hoofsare added to./clang-tidy-diff-scans.txt - [x] Assign PR to reviewer
Notes for Reviewer
- Add component and layer diagram for upcoming
v3.xrelease
Checklist for the PR Reviewer
- [x] Commits are properly organized and messages are according to the guideline
- [x] Code according to our coding style and naming conventions
- [x] Unit tests have been written for new behavior
- [x] Public API changes are documented via doxygen
- [x] Copyright owner are updated in the changed files
- [x] All touched (C/C++) source code files from
iceoryx_hoofshave been added to./clang-tidy-diff-scans.txt - [x] PR title describes the changes
Post-review Checklist for the PR Author
- [x] All open points are addressed and tracked via issues
References
- Closes #1295 (partly)
Codecov Report
Merging #1600 (bc37ad9) into master (65f20a7) will decrease coverage by
0.78%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #1600 +/- ##
==========================================
- Coverage 78.20% 77.42% -0.79%
==========================================
Files 360 366 +6
Lines 13862 14167 +305
Branches 1942 1984 +42
==========================================
+ Hits 10841 10969 +128
- Misses 2418 2569 +151
- Partials 603 629 +26
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 77.08% <ø> (-0.78%) |
:arrow_down: |
| unittests_timing | 15.57% <ø> (-0.04%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ceoryx_hoofs/include/iceoryx_hoofs/log/logging.hpp | 50.00% <0.00%> (-50.00%) |
:arrow_down: |
| iceoryx_hoofs/source/posix_wrapper/mutex.cpp | 43.54% <0.00%> (-41.75%) |
:arrow_down: |
| ...osh/include/iceoryx_posh/internal/popo/trigger.inl | 90.00% <0.00%> (-10.00%) |
:arrow_down: |
| ...lude/iceoryx_posh/internal/popo/base_publisher.inl | 90.90% <0.00%> (-9.10%) |
:arrow_down: |
| iceoryx_posh/source/popo/trigger_handle.cpp | 82.53% <0.00%> (-7.12%) |
:arrow_down: |
| ...hoofs/include/iceoryx_hoofs/internal/cxx/stack.inl | 93.75% <0.00%> (-6.25%) |
:arrow_down: |
| iceoryx_hoofs/source/concurrent/loffli.cpp | 85.71% <0.00%> (-5.72%) |
:arrow_down: |
| ...ceoryx_dust/source/posix_wrapper/message_queue.cpp | 63.58% <0.00%> (-5.44%) |
:arrow_down: |
| iceoryx_dust/source/posix_wrapper/named_pipe.cpp | 52.10% <0.00%> (-4.22%) |
:arrow_down: |
| ...lude/iceoryx_posh/internal/mepoo/mepoo_segment.inl | 91.11% <0.00%> (-4.13%) |
:arrow_down: |
| ... and 97 more |
The first two commits can be squashed
@dkroenke Typically, I prefer to keep separate things in separate commits, so you can later e.g. revert them individually with git revert. I can squash those commits, if you feel this is too much overhead.
@elfenpiff
Please add stack and variant queue to the Buffer table.
:heavy_check_mark: I didn't add VariantQueue as it will be moved to iceoryx_posh soon and has variable attributes.