iox #1394 fix axivion violation for unique ptr inl

[saif-at-github]

Pre-Review Checklist for the PR Author

1. [x] Code follows the coding style of CONTRIBUTING.md
2. [x] Tests follow the best practice for testing
3. [x] Changelog updated in the unreleased section including API breaking changes
4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
5. [x] Commits messages are according to this guideline
   • [x] Commit messages have the issue ID (iox-#123 commit text)
   • [x] Commit messages are signed (git commit -s)
   • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. [x] Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. [x] Relevant issues are linked
8. [x] Add sensible notes for the reviewer
9. [ ] All checks have passed (except task-list-completed)
10. [x] All touched (C/C++) source code files are added to ./clang-tidy-diff-scans.txt
11. [x] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

• [ ] Commits are properly organized and messages are according to the guideline
• [ ] Code according to our coding style and naming conventions
• [ ] Unit tests have been written for new behavior
• [ ] Public API changes are documented via doxygen
• [ ] Copyright owner are updated in the changed files
• [ ] All touched (C/C++) source code files have been added to ./clang-tidy-diff-scans.txt
• [ ] PR title describes the changes

Post-review Checklist for the PR Author

1. [ ] All open points are addressed and tracked via issues

References

• Closes TBD

[mossmaurice]

@saif-at-github I think you branched off a feature branch, I can see your string changes being included in this PR, too. I always try to start with a:

git fetch --all
git checkout origin/master
git branch iox-#1234-foo-bar
git checkout iox-#1234-foo-bar
# Make the code changes

[FerdinandSpitzschnueffler]

@saif-at-github There are still a few TODOS. Is this PR a work in progress?

[codecov[bot]]

Codecov Report

Merging #1586 (0202007) into master (1da4f68) will increase coverage by 0.04%. The diff coverage is 100.00%.

:exclamation: Current head 0202007 differs from pull request most recent head dbfb343. Consider uploading reports for the commit dbfb343 to get more accurate results

@@            Coverage Diff             @@
##           master    #1586      +/-   ##
==========================================
+ Coverage   77.42%   77.46%   +0.04%     
==========================================
  Files         366      366              
  Lines       14160    14160              
  Branches     1984     1984              
==========================================
+ Hits        10963    10969       +6     
+ Misses       2569     2562       -7     
- Partials      628      629       +1     

Flag	Coverage Δ
unittests	77.11% <100.00%> (+0.04%)	:arrow_up:
unittests_timing	15.58% <0.00%> (-0.02%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../include/iceoryx_hoofs/internal/cxx/unique_ptr.inl	97.77% <100.00%> (ø)
iceoryx_hoofs/source/concurrent/loffli.cpp	85.71% <0.00%> (-2.86%)	:arrow_down:
iceoryx_posh/source/roudi/port_manager.cpp	85.36% <0.00%> (+1.31%)	:arrow_up:

[saif-at-github]

@FerdinandSpitzschnueffler the TODO is kept only for AutosarC++19_03-A13.5.5 it may require a separate PR to address all of these at once.

[mossmaurice]

@saif-at-github FYI I'm doing a small bugfix in cxx::unique_ptr in #1685, this might affect some violations.

[mossmaurice]

@FerdinandSpitzschnueffler @elfenpiff Could you please review this PR? Thanks :pray: