iox #1394 fix axivion violation for string

[saif-at-github]

Pre-Review Checklist for the PR Author

1. [x] Code follows the coding style of CONTRIBUTING.md
2. [x] ~~Tests follow the best practice for testing~~
3. [x] Changelog updated in the unreleased section including API breaking changes
4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
5. [x] Commits messages are according to this guideline
   • [x] Commit messages have the issue ID (iox-#123 commit text)
   • [x] Commit messages are signed (git commit -s)
   • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. [x] Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. [x] Relevant issues are linked
8. [x] Add sensible notes for the reviewer
9. [x] All checks have passed (except task-list-completed)
10. [x] All touched (C/C++) source code files are added to ./clang-tidy-diff-scans.txt
11. [ ] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

• [ ] Commits are properly organized and messages are according to the guideline
• [ ] Code according to our coding style and naming conventions
• [ ] Unit tests have been written for new behavior
• [ ] Public API changes are documented via doxygen
• [ ] Copyright owner are updated in the changed files
• [ ] All touched (C/C++) source code files have been added to ./clang-tidy-diff-scans.txt
• [ ] PR title describes the changes

Post-review Checklist for the PR Author

1. [ ] All open points are addressed and tracked via issues

References

• Relates #1394

[mossmaurice]

@saif-at-github There are some conflicts in string_internal.hpp. Could you please rebase onto master?

[codecov[bot]]

Codecov Report

Merging #1582 (1d870f0) into master (e776718) will decrease coverage by 0.02%. The diff coverage is 98.18%.

:exclamation: Current head 1d870f0 differs from pull request most recent head dbb9c7e. Consider uploading reports for the commit dbb9c7e to get more accurate results

@@            Coverage Diff             @@
##           master    #1582      +/-   ##
==========================================
- Coverage   77.40%   77.37%   -0.03%     
==========================================
  Files         367      367              
  Lines       14248    14247       -1     
  Branches     1992     1992              
==========================================
- Hits        11028    11024       -4     
- Misses       2590     2592       +2     
- Partials      630      631       +1     

Flag	Coverage Δ
unittests	77.03% <98.18%> (-0.03%)	:arrow_down:
unittests_timing	15.68% <30.90%> (+<0.01%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
iceoryx_hoofs/include/iceoryx_hoofs/cxx/string.hpp	100.00% <ø> (ø)
...oofs/include/iceoryx_hoofs/internal/cxx/string.inl	98.86% <98.18%> (+<0.01%)	:arrow_up:
iceoryx_hoofs/source/concurrent/loffli.cpp	80.00% <0.00%> (-5.72%)	:arrow_down:
iceoryx_hoofs/source/posix_wrapper/thread.cpp	40.54% <0.00%> (-0.56%)	:arrow_down:
.../include/iceoryx_hoofs/memory/relative_pointer.inl	96.42% <0.00%> (-0.13%)	:arrow_down:
...nternal/popo/building_blocks/chunk_distributor.inl	96.15% <0.00%> (-0.06%)	:arrow_down:
...oryx_hoofs/source/posix_wrapper/access_control.cpp	64.70% <0.00%> (ø)
...hoofs/source/posix_wrapper/posix_access_rights.cpp	76.08% <0.00%> (ø)
.../include/iceoryx_hoofs/memory/relative_pointer.hpp	100.00% <0.00%> (ø)
... and 6 more