iceoryx
iceoryx copied to clipboard
iox-#1564 Move DDS gateway
Pre-Review Checklist for the PR Author
- [x] Code follows the coding style of CONTRIBUTING.md
- [x] Tests follow the best practice for testing
- [x] Changelog updated in the unreleased section including API breaking changes
- [x] Branch follows the naming format (
iox-123-this-is-a-branch
) - [x] Commits messages are according to this guideline
- [x] Commit messages have the issue ID (
iox-#123 commit text
) - [x] Commit messages are signed (
git commit -s
) - [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
- [x] Commit messages have the issue ID (
- [x] Update the PR title
- Follow the same conventions as for commit messages
- Link to the relevant issue
- [x] Relevant issues are linked
- [x] Add sensible notes for the reviewer
- [x] All checks have passed (except
task-list-completed
) - [x] All touched (C/C++) source code files are added to
./clang-tidy-diff-scans.txt
- [x] Assign PR to reviewer
Notes for Reviewer
- Move Cyclone DDS Gateway to separate repository
Checklist for the PR Reviewer
- [x] Commits are properly organized and messages are according to the guideline
- [x] Code according to our coding style and naming conventions
- [x] Unit tests have been written for new behavior
- [x] Public API changes are documented via doxygen
- [x] Copyright owner are updated in the changed files
- [x] All touched (C/C++) source code files have been added to
./clang-tidy-diff-scans.txt
- [x] PR title describes the changes
Post-review Checklist for the PR Author
- [x] All open points are addressed and tracked via issues
References
- Closes #1564
Codecov Report
Merging #1565 (e513da7) into master (765d49c) will increase coverage by
1.26%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1565 +/- ##
==========================================
+ Coverage 75.09% 76.36% +1.26%
==========================================
Files 369 360 -9
Lines 14219 13865 -354
Branches 1988 1941 -47
==========================================
- Hits 10678 10588 -90
+ Misses 2952 2702 -250
+ Partials 589 575 -14
Flag | Coverage Δ | |
---|---|---|
unittests | 76.01% <ø> (+1.25%) |
:arrow_up: |
unittests_timing | 15.57% <ø> (+0.38%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
iceoryx_posh/source/mepoo/chunk_header.cpp | 96.29% <0.00%> (-2.47%) |
:arrow_down: |
.../include/iceoryx_posh/internal/gateway/channel.inl | 88.88% <0.00%> (-2.03%) |
:arrow_down: |
...eoryx_dust/include/iceoryx_dust/cxx/objectpool.hpp | 25.46% <0.00%> (+0.62%) |
:arrow_up: |
iceoryx_hoofs/source/concurrent/loffli.cpp | 88.57% <0.00%> (+8.57%) |
:arrow_up: |
.../iceoryx_posh/internal/gateway/gateway_generic.inl | 91.66% <0.00%> (+25.99%) |
:arrow_up: |
@elBoberido
Please update
installation-guide-for-contributors.md
. It mentions that iceoryx_meta also contains the dds gateway.
:heavy_check_mark:
iceoryx_components_diagram_nextgen_release.puml
might also need updates
Added this as a item to #1295.
Correct build is in the other Pull-Request ensured and we will merge to avoid cyclic dependencies.