iceoryx icon indicating copy to clipboard operation
iceoryx copied to clipboard

Published 20 hours ago • verified publisher icon eclipse-iceoryx

Enable `Wsign-compare` compiler warning in tests

Open dkroenke opened this issue 1 year ago • 0 comments

Brief feature description

Currently the test code in posh and hoofs has certain cases where int types with a wrong sign are compared. By enabling the compiler warning we can get rid of them.

  • [ ] Remove set(TEST_CXX_FLAGS -Wno-sign-compare) in CMakeLists.txt files from iceoryx posh and hoofs test folder
  • [ ] Add -Wsign-compare to the ICEORYX_C_WARNINGS in IceoryxPlatform.cmake
  • [ ] Fix all warnings

Acceptance criteria:

  • [ ] BUILD_STRICT Mode does not fail when building a complete iceoryx

dkroenke avatar Aug 02 '22 16:08 dkroenke