iceoryx icon indicating copy to clipboard operation
iceoryx copied to clipboard

iox-#1554 Add `Arithmetic` and `{In,De}crementable` to `NewType`

Open mossmaurice opened this issue 1 year ago • 1 comments

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of CONTRIBUTING.md
  2. [x] Tests follow the best practice for testing
  3. [x] Changelog updated in the unreleased section including API breaking changes
  4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  5. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID (iox-#123 commit text)
    • [x] Commit messages are signed (git commit -s)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [x] Relevant issues are linked
  8. [x] Add sensible notes for the reviewer
  9. [x] All checks have passed (except task-list-completed)
  10. [ ] All touched (C/C++) source code files are added to ./clang-tidy-diff-scans.txt
  11. [x] Assign PR to reviewer

Notes for Reviewer

  • Extend NewType pattern with Arithmetic, Incrementable and Decrementable

Checklist for the PR Reviewer

  • [ ] Commits are properly organized and messages are according to the guideline
  • [ ] Code according to our coding style and naming conventions
  • [ ] Unit tests have been written for new behavior
    • [ ] Each unit test case has a unique UUID
  • [ ] Public API changes are documented via doxygen
  • [ ] Copyright owner are updated in the changed files
  • [ ] All touched (C/C++) source code files have been added to ./clang-tidy-diff-scans.txt
  • [ ] PR title describes the changes

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

  • Closes #1554 (partly)

mossmaurice avatar Aug 02 '22 08:08 mossmaurice

Codecov Report

Merging #1555 (a243847) into master (53fa0f7) will increase coverage by 0.04%. The diff coverage is 100.00%.

:exclamation: Current head a243847 differs from pull request most recent head bdbb111. Consider uploading reports for the commit bdbb111 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1555      +/-   ##
==========================================
+ Coverage   75.20%   75.25%   +0.04%     
==========================================
  Files         395      398       +3     
  Lines       15501    15525      +24     
  Branches     2198     2198              
==========================================
+ Hits        11658    11683      +25     
  Misses       3152     3152              
+ Partials      691      690       -1     
Flag Coverage Δ
unittests 74.91% <100.00%> (+0.04%) :arrow_up:
unittests_timing 15.11% <11.76%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/design/include/iox/detail/newtype/comparable.hpp 100.00% <ø> (ø)
...ofs/design/include/iox/detail/newtype/sortable.hpp 100.00% <ø> (ø)
...oryx_hoofs/memory/include/iox/relative_pointer.hpp 100.00% <ø> (ø)
...ceoryx_hoofs/design/include/iox/detail/newtype.inl 93.33% <100.00%> (ø)
...s/design/include/iox/detail/newtype/arithmetic.hpp 100.00% <100.00%> (ø)
...esign/include/iox/detail/newtype/decrementable.hpp 100.00% <100.00%> (ø)
...esign/include/iox/detail/newtype/incrementable.hpp 100.00% <100.00%> (ø)
...ofs/design/include/iox/detail/newtype/internal.hpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

codecov[bot] avatar Aug 02 '22 08:08 codecov[bot]