iceoryx icon indicating copy to clipboard operation
iceoryx copied to clipboard

Iox #1516 support for gtest vendor package

Open dkroenke opened this issue 1 year ago • 2 comments

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of CONTRIBUTING.md
  2. [x] Tests follow the best practice for testing
  3. [x] Changelog updated in the unreleased section including API breaking changes
  4. [x] Branch follows the naming format (iox-#123-this-is-a-branch)
  5. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID (iox-#123 commit text)
    • [x] Commit messages are signed (git commit -s)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [ ] Relevant issues are linked
  8. [x] Add sensible notes for the reviewer
  9. [ ] All checks have passed (except task-list-completed)
  10. [x] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • [x] Commits are properly organized and messages are according to the guideline
  • [x] Code according to our coding style and naming conventions
  • [ ] Unit tests have been written for new behavior
    • [ ] Each unit test case has a unique UUID
  • [x] Public API changes are documented via doxygen
  • [ ] Copyright owner are updated in the changed files
  • [x] PR title describes the changes

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

  • Closes TBD

dkroenke avatar Jul 18 '22 17:07 dkroenke

@dkroenke Could you please link the PR to an issue under "References? Have you checked the ROS CI? Where can I find the latest build log?

mossmaurice avatar Aug 04 '22 09:08 mossmaurice

Codecov Report

Merging #1523 (42b5486) into master (baeace3) will decrease coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   78.91%   78.90%   -0.02%     
==========================================
  Files         379      379              
  Lines       14486    14486              
  Branches     2028     2028              
==========================================
- Hits        11432    11430       -2     
- Misses       2428     2429       +1     
- Partials      626      627       +1     
Flag Coverage Δ
unittests 78.56% <ø> (-0.02%) :arrow_down:
unittests_timing 14.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_posh/source/mepoo/shared_chunk.cpp 93.33% <0.00%> (-3.34%) :arrow_down:
.../include/iceoryx_hoofs/design_pattern/creation.hpp 100.00% <0.00%> (ø)

codecov[bot] avatar Aug 04 '22 14:08 codecov[bot]