iceoryx icon indicating copy to clipboard operation
iceoryx copied to clipboard

iox-#1504 Integration branch for iceoryx v2.0.3 release

Open elBoberido opened this issue 1 year ago • 1 comments

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of CONTRIBUTING.md
  2. [x] Tests follow the best practice for testing
  3. [x] Changelog updated in the unreleased section including API breaking changes
  4. [x] Branch follows the naming format (iox-#123-this-is-a-branch)
  5. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID (iox-#123 commit text)
    • [x] Commit messages are signed (git commit -s)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [x] Relevant issues are linked
  8. [x] Add sensible notes for the reviewer
  9. [x] All checks have passed (except task-list-completed)
  10. [ ] Assign PR to reviewer

Notes for Reviewer

This is the integration branch for all PRs which will be part of iceoryx v2.0.3. This branch must pass the ROS CI before it can be merged to the release branch.

  • [ ] set release date for bugfix release
  • [ ] ROS 2 CI has run
  • [ ] Confirm that generated include folders don't change for release 2.0.3
  • [ ] set version numbers to 2.0.3 using tools/iceoryx_release script

Checklist for the PR Reviewer

  • [ ] Commits are properly organized and messages are according to the guideline
  • [ ] Code according to our coding style and naming conventions
  • [ ] Unit tests have been written for new behavior
    • [ ] Each unit test case has a unique UUID
  • [ ] Public API changes are documented via doxygen
  • [ ] Copyright owner are updated in the changed files
  • [ ] PR title describes the changes

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

  • Relates to #1504
  • Closes #1338
  • Closes #1440
  • Closes #1476
  • Closes #1481

elBoberido avatar Jul 14 '22 14:07 elBoberido

Codecov Report

Merging #1505 (896be65) into release_2.0 (418d929) will increase coverage by 0.03%. The diff coverage is 58.33%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release_2.0    #1505      +/-   ##
===============================================
+ Coverage        78.89%   78.93%   +0.03%     
===============================================
  Files              370      370              
  Lines            14705    14716      +11     
  Branches          2059     2061       +2     
===============================================
+ Hits             11602    11616      +14     
+ Misses            2420     2419       -1     
+ Partials           683      681       -2     
Flag Coverage Δ
unittests 78.15% <58.33%> (+0.02%) :arrow_up:
unittests_timing 15.48% <0.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_posh/source/roudi/process_manager.cpp 64.64% <0.00%> (ø)
iceoryx_hoofs/source/posix_wrapper/file_lock.cpp 40.54% <50.00%> (+0.12%) :arrow_up:
...sh/include/iceoryx_posh/internal/popo/wait_set.inl 89.81% <66.66%> (-1.37%) :arrow_down:
...osh/internal/popo/building_blocks/chunk_sender.inl 87.85% <100.00%> (+0.11%) :arrow_up:
...lude/iceoryx_posh/internal/popo/base_publisher.inl 90.90% <0.00%> (-9.10%) :arrow_down:
...nternal/roudi/introspection/port_introspection.inl 82.84% <0.00%> (+0.72%) :arrow_up:
iceoryx_hoofs/source/posix_wrapper/timer.cpp 63.90% <0.00%> (+0.82%) :arrow_up:
iceoryx_hoofs/source/concurrent/loffli.cpp 91.42% <0.00%> (+11.42%) :arrow_up:

codecov[bot] avatar Jul 14 '22 14:07 codecov[bot]

@dkroenke @elBoberido Due to #1850 I would suggest a v2.0.3 release end of CW3. Today, I will trigger the ROS 2 CI.

mossmaurice avatar Jan 17 '23 07:01 mossmaurice

@clalancette With an additional --packages-up-to rmw_cyclonedds_cpp the Linux job ran just fine this morning. With the default args there was Java error. I suppose, that's a Jenkin issue and nothing we have to chase after?

cc @dkroenke @elBoberido

mossmaurice avatar Jan 17 '23 16:01 mossmaurice

Re-triggered the build this morning:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

mossmaurice avatar Jan 18 '23 14:01 mossmaurice

@elBoberido @dkroenke After #1856 was merged to master I'll cherry pick the commits to this PR to be included in v2.0.3

mossmaurice avatar Jan 24 '23 21:01 mossmaurice

Just re-triggered the build including the changes from #1856:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

cc @dkroenke @elBoberido

mossmaurice avatar Jan 25 '23 14:01 mossmaurice

@mossmaurice @elBoberido

Checked that the include directories of the installed headers are still unique:

isolated workspace:

  • ros2_humble/install/iceoryx_hoofs/include/iceoryx/v2.0.2/iceoryx_hoofs
  • ros2_humble/install/iceoryx_hoofs/include/iceoryx/v2.0.3/iceoryx_hoofs

merged workspace:

  • ros2_humble/install/include/iceoryx/v2.0.2/iceoryx_hoofs
  • ros2_humble/install/include/iceoryx/v2.0.3/iceoryx_hoofs

dkroenke avatar Jan 30 '23 15:01 dkroenke