iceoryx icon indicating copy to clipboard operation
iceoryx copied to clipboard

Typo error in initalizeSocket() in Unix Domain Socket

Open hemalbavishi opened this issue 2 years ago • 4 comments

Required information

I observed small typo error in cxx::expected<IpcChannelError> initalizeSocket() noexcept

Operating system: NA Compiler version: NA

Observed result or behaviour: Typo error

Expected result or behaviour: It should be changed to cxx::expected<IpcChannelError> initializeSocket() noexcept;

Conditions where it occurred / Performed steps: NA

hemalbavishi avatar Jun 30 '22 09:06 hemalbavishi

@hemalbavishi Would you like to adjust this? It is not public API so this should be an easy fix and we guide you also through our little more complex contribution process :smile:

elfenpiff avatar Jun 30 '22 09:06 elfenpiff

@elfenpiff : Sure, Please let me know the complex process to fix this;).

Cheers!

hemalbavishi avatar Jun 30 '22 11:06 hemalbavishi

@hemalbavishi

  1. You have to create an eclipse account and sign the ECA.
  2. Create a branch with the prefix iox-#1439-some-meaningful-name where iox-#1439 is this issue number
  3. Then your commit message requires the prefix iox-#1439 as well and has to be signed. So you commit with git commit -sm "iox-#1439 my commit message".

This is it, if you have questions take a look at the https://github.com/eclipse-iceoryx/iceoryx/blob/master/CONTRIBUTING.md or ask me here.

elfenpiff avatar Jun 30 '22 13:06 elfenpiff

@hemalbavishi is this still on your todo list? If not I'll fix it in one of my open PRs.

elBoberido avatar Nov 29 '23 22:11 elBoberido