iceoryx icon indicating copy to clipboard operation
iceoryx copied to clipboard

Iox #1032 error handling prototype

Open MatthiasKillat opened this issue 2 years ago • 1 comments

Pre-Review Checklist for the PR Author

  1. [ ] Code follows the coding style of CONTRIBUTING.md
  2. [ ] Tests follow the best practice for testing
  3. [ ] Changelog updated in the unreleased section including API breaking changes
  4. [ ] Branch follows the naming format (iox-#123-this-is-a-branch)
  5. [ ] Commits messages are according to this guideline
    • [ ] Commit messages have the issue ID (iox-#123 commit text)
    • [ ] Commit messages are signed (git commit -s)
    • [ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. [ ] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [ ] Relevant issues are linked
  8. [ ] Add sensible notes for the reviewer
  9. [ ] All checks have passed (except task-list-completed)
  10. [ ] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • [ ] Commits are properly organized and messages are according to the guideline
  • [ ] Code according to our coding style and naming conventions
  • [ ] Unit tests have been written for new behavior
    • [ ] Each unit test case has a unique UUID
  • [ ] Public API changes are documented via doxygen
  • [ ] Copyright owner are updated in the changed files
  • [ ] PR title describes the changes

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

  • Closes TBD

MatthiasKillat avatar Jun 27 '22 17:06 MatthiasKillat

Only a draft, but shows the overall structure. Will be restructured as needed and the code style will be changed in a refactoring. Tests demonstrate the functionality and interface (most do not check anything). Tests can be extended if we use the test_handling to actually check for errors being raised.

MatthiasKillat avatar Jun 27 '22 17:06 MatthiasKillat

@elBoberido Will be closed later and reopened as a new PR based on https://github.com/eclipse-iceoryx/iceoryx/pull/1656 (to exchange the handler). The reason is that new ideas/restrictions will only allow part of the code to be reused ...

MatthiasKillat avatar Oct 26 '22 15:10 MatthiasKillat

Experimental prototype. Version to be merged will be developed in another branch https://github.com/ApexAI/iceoryx/tree/iox-1032-new-error-handling-api

MatthiasKillat avatar Jan 25 '23 16:01 MatthiasKillat