iceoryx icon indicating copy to clipboard operation
iceoryx copied to clipboard
verified publisher icon eclipse-iceoryx

iox#1394-Fix axivion violations

Open saif-at-github opened this issue 3 years ago • 4 comments

Pre-Review Checklist for the PR Author

  1. [ ] Code follows the coding style of CONTRIBUTING.md
  2. [ ] Tests follow the best practice for testing
  3. [ ] Changelog updated in the unreleased section including API breaking changes
  4. [ ] Branch follows the naming format (iox-#123-this-is-a-branch)
  5. [ ] Commits messages are according to this guideline
    • [ ] Commit messages have the issue ID (iox-#123 commit text)
    • [ ] Commit messages are signed (git commit -s)
    • [ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. [ ] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [ ] Relevant issues are linked
  8. [ ] Add sensible notes for the reviewer
  9. [ ] All checks have passed (except task-list-completed)
  10. [ ] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • [ ] Commits are properly organized and messages are according to the guideline
  • [ ] Code according to our coding style and naming conventions
  • [x] Unit tests have been written for new behavior
    • [x] Each unit test case has a unique UUID
  • [x] Public API changes are documented via doxygen
  • [ ] Copyright owner are updated in the changed files
  • [ ] PR title describes the changes

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

  • Closes TBD
  • Relates #1394

saif-at-github avatar Jun 13 '22 11:06 saif-at-github

See #1384 for additional comments.

elfenpiff avatar Jun 13 '22 14:06 elfenpiff

Note that the commit message should be like: iox-#xyz Fix axivion violations or iox-#xyz Fix static analysis violations. Ideally more specific (what or where are the main fixes), but that is maybe not easy here.

We should not mention specific rules in the commits but I imagine they need to be much more fixes so we need to think about how we give the commits a little more expressive descriptions.

MatthiasKillat avatar Jun 15 '22 13:06 MatthiasKillat

Note that the commit message should be like: iox-#xyz Fix axivion violations or iox-#xyz Fix static analysis violations. Ideally more specific (what or where are the main fixes), but that is maybe not easy here.

We should not mention specific rules in the commits but I imagine they need to be much more fixes so we need to think about how we give the commits a little more expressive descriptions.

Sure the commit message reworded

saif-at-github avatar Jun 28 '22 14:06 saif-at-github

@saif-at-github Will review later but we should fix the CI first I think. There are also conflicts with master now.

MatthiasKillat avatar Sep 16 '22 16:09 MatthiasKillat

Closed. We will fix violations in deadline_timer and filesystem in separate PRs. The static code analysis is already completed for deadline_timer. Thus there is no reason to solve conflicts now.

Helplets.cpp will be refactored and requires.cpp will be removed in the near future.

MatthiasKillat avatar Sep 29 '22 08:09 MatthiasKillat