iceoryx
iceoryx copied to clipboard
iox#1394-Fix axivion violations
Pre-Review Checklist for the PR Author
- [ ] Code follows the coding style of CONTRIBUTING.md
- [ ] Tests follow the best practice for testing
- [ ] Changelog updated in the unreleased section including API breaking changes
- [ ] Branch follows the naming format (
iox-#123-this-is-a-branch
) - [ ] Commits messages are according to this guideline
- [ ] Commit messages have the issue ID (
iox-#123 commit text
) - [ ] Commit messages are signed (
git commit -s
) - [ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
- [ ] Commit messages have the issue ID (
- [ ] Update the PR title
- Follow the same conventions as for commit messages
- Link to the relevant issue
- [ ] Relevant issues are linked
- [ ] Add sensible notes for the reviewer
- [ ] All checks have passed (except
task-list-completed
) - [ ] Assign PR to reviewer
Notes for Reviewer
Checklist for the PR Reviewer
- [ ] Commits are properly organized and messages are according to the guideline
- [ ] Code according to our coding style and naming conventions
- [x] Unit tests have been written for new behavior
- [x] Each unit test case has a unique UUID
- [x] Public API changes are documented via doxygen
- [ ] Copyright owner are updated in the changed files
- [ ] PR title describes the changes
Post-review Checklist for the PR Author
- [ ] All open points are addressed and tracked via issues
References
- Closes TBD
- Relates #1394
See #1384 for additional comments.
Note that the commit message should be like: iox-#xyz Fix axivion violations
or iox-#xyz Fix static analysis violations
. Ideally more specific (what or where are the main fixes), but that is maybe not easy here.
We should not mention specific rules in the commits but I imagine they need to be much more fixes so we need to think about how we give the commits a little more expressive descriptions.
Note that the commit message should be like:
iox-#xyz Fix axivion violations
oriox-#xyz Fix static analysis violations
. Ideally more specific (what or where are the main fixes), but that is maybe not easy here.We should not mention specific rules in the commits but I imagine they need to be much more fixes so we need to think about how we give the commits a little more expressive descriptions.
Sure the commit message reworded
@saif-at-github Will review later but we should fix the CI first I think. There are also conflicts with master now.
Closed. We will fix violations in deadline_timer and filesystem in separate PRs. The static code analysis is already completed for deadline_timer. Thus there is no reason to solve conflicts now.
Helplets.cpp will be refactored and requires.cpp will be removed in the near future.